Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StateFunc to store values in lower case #17909

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

bill-rich
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15583

Output from acceptance testing:

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDBParameterGroup_ -timeout 120m
=== RUN   TestAccAWSDBParameterGroup_basic
=== PAUSE TestAccAWSDBParameterGroup_basic
=== RUN   TestAccAWSDBParameterGroup_caseWithMixedParameters
=== PAUSE TestAccAWSDBParameterGroup_caseWithMixedParameters
=== RUN   TestAccAWSDBParameterGroup_limit
=== PAUSE TestAccAWSDBParameterGroup_limit
=== RUN   TestAccAWSDBParameterGroup_Disappears
=== PAUSE TestAccAWSDBParameterGroup_Disappears
=== RUN   TestAccAWSDBParameterGroup_namePrefix
=== PAUSE TestAccAWSDBParameterGroup_namePrefix
=== RUN   TestAccAWSDBParameterGroup_generatedName
=== PAUSE TestAccAWSDBParameterGroup_generatedName
=== RUN   TestAccAWSDBParameterGroup_withApplyMethod
=== PAUSE TestAccAWSDBParameterGroup_withApplyMethod
=== RUN   TestAccAWSDBParameterGroup_Only
=== PAUSE TestAccAWSDBParameterGroup_Only
=== RUN   TestAccAWSDBParameterGroup_MatchDefault
=== PAUSE TestAccAWSDBParameterGroup_MatchDefault
=== RUN   TestAccAWSDBParameterGroup_updateParameters
=== PAUSE TestAccAWSDBParameterGroup_updateParameters
=== CONT  TestAccAWSDBParameterGroup_basic
=== CONT  TestAccAWSDBParameterGroup_withApplyMethod
=== CONT  TestAccAWSDBParameterGroup_MatchDefault
=== CONT  TestAccAWSDBParameterGroup_Only
=== CONT  TestAccAWSDBParameterGroup_caseWithMixedParameters
=== CONT  TestAccAWSDBParameterGroup_updateParameters
=== CONT  TestAccAWSDBParameterGroup_namePrefix
=== CONT  TestAccAWSDBParameterGroup_limit
=== CONT  TestAccAWSDBParameterGroup_Disappears
=== CONT  TestAccAWSDBParameterGroup_generatedName
--- PASS: TestAccAWSDBParameterGroup_Disappears (12.86s)
--- PASS: TestAccAWSDBParameterGroup_generatedName (16.50s)
--- PASS: TestAccAWSDBParameterGroup_namePrefix (20.30s)
--- PASS: TestAccAWSDBParameterGroup_Only (23.25s)
--- PASS: TestAccAWSDBParameterGroup_MatchDefault (25.28s)
--- PASS: TestAccAWSDBParameterGroup_caseWithMixedParameters (27.35s)
--- PASS: TestAccAWSDBParameterGroup_withApplyMethod (29.02s)
--- PASS: TestAccAWSDBParameterGroup_updateParameters (42.27s)
--- PASS: TestAccAWSDBParameterGroup_basic (47.21s)
--- PASS: TestAccAWSDBParameterGroup_limit (50.32s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	50.358s

@bill-rich bill-rich requested a review from a team as a code owner March 4, 2021 01:22
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 4, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 4, 2021
@bill-rich bill-rich force-pushed the b-aws_db_parameter_group_downcase branch from 3193eaa to a72bba1 Compare March 4, 2021 03:54
@bill-rich bill-rich removed the needs-triage Waiting for first response or review from a maintainer. label Mar 4, 2021
@YakDriver YakDriver self-assigned this Mar 18, 2021
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

It seems like something that should be handleable by docs but this saves people from themselves. We probably all need a bit of that!

Acceptance tests (GovCloud):

--- PASS: TestAccAWSDBParameterGroup_Disappears (17.90s)
--- PASS: TestAccAWSDBParameterGroup_generatedName (22.09s)
--- PASS: TestAccAWSDBParameterGroup_namePrefix (22.11s)
--- PASS: TestAccAWSDBParameterGroup_caseWithMixedParameters (22.44s)
--- PASS: TestAccAWSDBParameterGroup_Only (22.60s)
--- PASS: TestAccAWSDBParameterGroup_withApplyMethod (25.61s)
--- PASS: TestAccAWSDBParameterGroup_MatchDefault (29.21s)
--- PASS: TestAccAWSDBParameterGroup_updateParameters (43.58s)
--- PASS: TestAccAWSDBParameterGroup_limit (50.24s)
--- PASS: TestAccAWSDBParameterGroup_basic (62.01s)

Tests on commercial:

--- PASS: TestAccAWSDBParameterGroup_Disappears (15.04s)
--- PASS: TestAccAWSDBParameterGroup_generatedName (18.57s)
--- PASS: TestAccAWSDBParameterGroup_namePrefix (18.62s)
--- PASS: TestAccAWSDBParameterGroup_MatchDefault (21.30s)
--- PASS: TestAccAWSDBParameterGroup_Only (22.51s)
--- PASS: TestAccAWSDBParameterGroup_withApplyMethod (23.82s)
--- PASS: TestAccAWSDBParameterGroup_caseWithMixedParameters (31.54s)
--- PASS: TestAccAWSDBParameterGroup_limit (45.56s)
--- PASS: TestAccAWSDBParameterGroup_updateParameters (47.52s)
--- PASS: TestAccAWSDBParameterGroup_basic (57.63s)

@YakDriver YakDriver added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 18, 2021
.changelog/17909.txt Outdated Show resolved Hide resolved
Co-authored-by: Dirk Avery <31492422+YakDriver@users.noreply.github.com>
@bill-rich bill-rich merged commit 3cc1d85 into main Mar 18, 2021
@bill-rich bill-rich deleted the b-aws_db_parameter_group_downcase branch March 18, 2021 17:56
@github-actions github-actions bot added this to the v3.33.0 milestone Mar 18, 2021
github-actions bot pushed a commit that referenced this pull request Mar 18, 2021
@ghost
Copy link

ghost commented Mar 18, 2021

This has been released in version 3.33.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 18, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants