Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'aws_subnet_nacl_association' resource #17648

Closed
geofflancaster opened this issue Feb 17, 2021 · 4 comments
Closed

Add support for 'aws_subnet_nacl_association' resource #17648

geofflancaster opened this issue Feb 17, 2021 · 4 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/ec2 Issues and PRs that pertain to the ec2 service.

Comments

@geofflancaster
Copy link
Contributor

geofflancaster commented Feb 17, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Cloudformation has EC2:SubnetNetworkAclAssociation but there is not an equivalent resource in terraform.

New or Affected Resource(s)

  • aws_subnet_nacl_association

Potential Terraform Configuration

resource "aws_subnet_nacl_association" "association" {
  subnet_id = ""
  network_acl_id = ""
}

References

Existing issue: #5466

Steps to implement:
DescribeNetworkAcls and filter by association.subnet-id to determine the AssociationId.
ReplaceNetworkAclAssociation providing the AssociationId and NetworkAclId will reassign appropriately.

  • #0000
@geofflancaster geofflancaster added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 17, 2021
@ghost ghost added the service/ec2 Issues and PRs that pertain to the ec2 service. label Feb 17, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 17, 2021
@geofflancaster
Copy link
Contributor Author

geofflancaster commented Feb 17, 2021

I've started coding this out but I do not have any Go experience. Any assistance, especially with a valid test suite (I am attempting to adapt one from an existing resource) would be appreciated.

geofflancaster@49408fa

@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Feb 17, 2021
@bill-rich bill-rich removed the needs-triage Waiting for first response or review from a maintainer. label Feb 19, 2021
@edmundcraske-bjss
Copy link
Contributor

Looks like #16660, #12364, and #1034 are all related to this... Should this be closed as a duplicate?

@geofflancaster
Copy link
Contributor Author

new MR incoming. Closing this.

@ghost
Copy link

ghost commented May 9, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

No branches or pull requests

4 participants