Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/db_instance: include check for first char in final_snapshot_identifier ValidationFunc #16885

Merged
merged 2 commits into from
Jan 11, 2021
Merged

resource/db_instance: include check for first char in final_snapshot_identifier ValidationFunc #16885

merged 2 commits into from
Jan 11, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Dec 23, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16883

Release note for CHANGELOG:

resource/db_instance: update plan-time validation for final_snapshot_identifier

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@anGie44 anGie44 requested a review from a team as a code owner December 23, 2020 04:38
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 23, 2020
@YakDriver YakDriver self-assigned this Jan 8, 2021
@YakDriver
Copy link
Member

YakDriver commented Jan 8, 2021 •
edited
Loading

There's a bunch of failures but most are pre-existing. I think some are flaky. If you're comfortable with these failures being unrelated, let me know and I can approve regardless.

Failed on PR but not last night's suite:

--- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName_VpcSecurityGroupIds (1141.53s)
--- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_MaxAllocatedStorage (1202.63s)
--- FAIL: TestAccAWSDBInstance_SnapshotIdentifier_Io1Storage (1415.07s)

Failed on PR and last night's suite:

--- FAIL: TestAccAWSDBInstance_DbSubnetGroupName_RamShared (15.52s)
--- FAIL: TestAccAWSDBInstance_ec2Classic (417.59s)
--- FAIL: TestAccAWSDBInstance_MSSQL_Domain (1850.13s)
--- FAIL: TestAccAWSDBInstance_MSSQL_DomainSnapshotRestore (1890.29s)
--- FAIL: TestAccAWSDBInstance_MSSQL_TZ (20.99s)
--- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName_RamShared (737.96s)
--- FAIL: TestAccAWSDBInstance_S3Import (659.37s)
--- FAIL: TestAccAWSDBInstance_subnetGroup (115.20s)
--- FAIL: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName_RamShared (747.29s)

Passed on PR:

--- PASS: TestAccAWSDBInstance_AllowMajorVersionUpgrade (302.24s) ** Previously failed
--- PASS: TestAccAWSDBInstance_DeletionProtection (459.65s) ** Previously failed
--- PASS: TestAccAWSDBInstance_optionGroup (632.97s) ** Previously failed
--- PASS: TestAccAWSDBInstance_basic (386.98s)
--- PASS: TestAccAWSDBInstance_CACertificateIdentifier (489.02s)
--- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfiguration (488.81s)
--- PASS: TestAccAWSDBInstance_DbSubnetGroupName (302.03s)
--- PASS: TestAccAWSDBInstance_DbSubnetGroupName_VpcSecurityGroupIds (323.62s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MSSQL (706.66s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MySQL (822.36s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle (904.33s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Postgresql (570.15s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier (747.86s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier_SkipFinalSnapshot (589.94s)
--- PASS: TestAccAWSDBInstance_generatedName (363.09s)
--- PASS: TestAccAWSDBInstance_iamAuth (361.70s)
--- PASS: TestAccAWSDBInstance_IsAlreadyBeingDeleted (418.52s)
--- PASS: TestAccAWSDBInstance_kmsKey (240.56s)
--- PASS: TestAccAWSDBInstance_MaxAllocatedStorage (564.93s)
--- PASS: TestAccAWSDBInstance_MinorVersion (421.85s)
--- PASS: TestAccAWSDBInstance_MonitoringInterval (1075.85s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToDisabled (762.31s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToRemoved (824.63s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_RemovedToEnabled (519.51s)
--- PASS: TestAccAWSDBInstance_MySQL_SnapshotRestoreWithEngineVersion (2154.91s)
--- PASS: TestAccAWSDBInstance_namePrefix (299.46s)
--- PASS: TestAccAWSDBInstance_NoDeleteAutomatedBackups (663.10s)
--- PASS: TestAccAWSDBInstance_Password (429.06s)
--- PASS: TestAccAWSDBInstance_PerformanceInsightsEnabled_DisabledToEnabled (713.08s)
--- PASS: TestAccAWSDBInstance_PerformanceInsightsEnabled_EnabledToDisabled (943.17s)
--- PASS: TestAccAWSDBInstance_PerformanceInsightsKmsKeyId (1106.68s)
--- PASS: TestAccAWSDBInstance_PerformanceInsightsRetentionPeriod (885.93s)
--- PASS: TestAccAWSDBInstance_portUpdate (638.64s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb (1414.69s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllocatedStorage (1768.85s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllowMajorVersionUpgrade (1382.38s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AutoMinorVersionUpgrade (1143.18s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AvailabilityZone (1299.17s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupRetentionPeriod (1642.66s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupWindow (1340.93s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_CACertificateIdentifier (1188.64s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName (1230.28s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_IamDatabaseAuthenticationEnabled (1045.33s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaintenanceWindow (1172.75s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Monitoring (1291.27s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MultiAZ (1537.60s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_ParameterGroupName (1185.24s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_PerformanceInsightsEnabled (1769.80s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Port (995.43s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_VpcSecurityGroupIds (1159.23s)
--- PASS: TestAccAWSDBInstance_RestoreToPointInTime_SourceIdentifier (1435.59s)
--- PASS: TestAccAWSDBInstance_RestoreToPointInTime_SourceResourceID (1477.29s)
--- PASS: TestAccAWSDBInstance_separateIopsUpdate (699.45s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier (1320.51s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllocatedStorage (1308.20s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllowMajorVersionUpgrade (1749.90s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AutoMinorVersionUpgrade (1109.58s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AvailabilityZone (926.23s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod (1293.49s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod_Unset (1696.40s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupWindow (1367.74s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName (830.51s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName_VpcSecurityGroupIds (1364.16s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DeletionProtection (1119.53s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_IamDatabaseAuthenticationEnabled (1092.90s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaintenanceWindow (1102.68s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaxAllocatedStorage (1196.78s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Monitoring (1259.24s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ (1967.58s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ_SQLServer (3073.74s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_ParameterGroupName (1119.34s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_PerformanceInsightsEnabled (1549.16s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Port (1158.66s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Tags (1159.51s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds (1162.98s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds_Tags (1204.32s)
--- SKIP: TestAccAWSDBInstance_ReplicateSourceDb_DeletionProtection (0.00s)
--- SKIP: TestAccAWSDBInstance_SnapshotIdentifier_Tags_Unset (0.00s)

YakDriver
YakDriver approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anGie44 anGie44 added this to the v3.24.0 milestone Jan 11, 2021
@anGie44 anGie44 merged commit 9f4513f into master Jan 11, 2021
@anGie44 anGie44 deleted the b-final-snapshot-identifier-validation branch January 11, 2021 21:55
anGie44 added a commit that referenced this pull request Jan 11, 2021
@anGie44
Update CHANGELOG for #16885
2a47cbe
@ghost
Copy link

ghost commented Jan 15, 2021

This has been released in version 3.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 11, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.24.0
Development

Successfully merging this pull request may close these issues.

RDS Instance Validation Does Not Catch Invalid final_snapshot_identifiers
2 participants
@anGie44 @YakDriver