Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Amazon Managed Service for Grafana #16789

Closed
abuchanan920 opened this issue Dec 16, 2020 · 19 comments · Fixed by #22874 or #23712
Closed

Add support for Amazon Managed Service for Grafana #16789

abuchanan920 opened this issue Dec 16, 2020 · 19 comments · Fixed by #22874 or #23712
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. new-resource Introduces a new resource. service/grafana Issues and PRs that pertain to the grafana service.
Milestone

Comments

@abuchanan920
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Amazon has added a preview release of a managed Grafana service. Many users who are currently using EKS are using self-hosted Grafana instances for metrics dashboards.

New or Affected Resource(s)

Potential Terraform Configuration

References

https://aws.amazon.com/grafana/

@abuchanan920 abuchanan920 added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 16, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 16, 2020
@gdavison gdavison added upstream Addresses functionality related to the cloud provider. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 17, 2020
@gdavison
Copy link
Contributor

Thanks for submitting this, @abuchanan920. Since this is currently in preview, we will need to wait for AWS to release it in the AWS SDK for Go

@McTristan
Copy link

It is now GA!

@sobi3ch
Copy link

sobi3ch commented Sep 16, 2021

Thanks for submitting this, @abuchanan920. Since this is currently in preview, we will need to wait for AWS to release it in the AWS SDK for Go

Prometheus is in preview but it has support already.

@moserke
Copy link

moserke commented Sep 17, 2021

Sadly the difference between Grafana and Prometheus is that AWS has not release an API for the Grafana service, however they have for Prometheus. https://docs.aws.amazon.com/sdk-for-go/api. The terraform provider will not be able to implement this until AWS releases an API. If you have an account team it would be helpful to push on them to open a feature request or add you to it if it is already opened.

@damdo
Copy link

damdo commented Sep 17, 2021

I've created an issue on the AWS SDK for Go to support Grafana here: aws/aws-sdk-go#3894
You can react/comment on it to get more traction behind it.

@ksiebel-coachub
Copy link

Managed Grafana is now supported: https://docs.aws.amazon.com/sdk-for-go/api/service/managedgrafana/

@damdo
Copy link

damdo commented Oct 10, 2021

Great news! cc. @gdavison

@a-patel
Copy link

a-patel commented Oct 10, 2021

Great news!

@larstobi
Copy link
Contributor

aws/aws-sdk-go#4126

@mericano1
Copy link

Great news. Any updates on the terraform support for this ?

@tsposato
Copy link

https://docs.aws.amazon.com/sdk-for-go/api/service/managedgrafana/
Would be good to get this implemented now that the AWS SDK for Go supports it.

@sanarena
Copy link

Any update on this?

@qubusp
Copy link

qubusp commented Jan 25, 2022

Is there any development on that?

@AlexanderSchiff
Copy link
Contributor

Starting to work on this...

@breathingdust
Copy link
Member

Hi all 👋 Just letting you know that this is issue is featured on this quarters roadmap. If a PR exists to close the issue a maintainer will review and either make changes directly, or work with the original author to get the contribution merged. If you have written a PR to resolve the issue please ensure the "Allow edits from maintainers" box is checked. Thanks for your patience and we are looking forward to getting this merged soon!

@ewbankkit ewbankkit added new-data-source Introduces a new data source. new-resource Introduces a new resource. labels Feb 16, 2022
@ewbankkit ewbankkit added this to the Roadmap milestone Feb 16, 2022
@ewbankkit ewbankkit added service/grafana Issues and PRs that pertain to the grafana service. and removed upstream Addresses functionality related to the cloud provider. labels Feb 16, 2022
@ewbankkit ewbankkit removed this from the Roadmap milestone Feb 16, 2022
@ewbankkit ewbankkit added this to the v4.2.0 milestone Feb 16, 2022
@github-actions
Copy link

This functionality has been released in v4.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

This functionality has been released in v4.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@a-patel
Copy link

a-patel commented Mar 18, 2022

great news!

@github-actions
Copy link

github-actions bot commented May 7, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. new-resource Introduces a new resource. service/grafana Issues and PRs that pertain to the grafana service.
Projects
None yet