Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Group Description Support #1643

Closed
hashibot opened this issue Sep 13, 2017 · 4 comments
Closed

Security Group Description Support #1643

hashibot opened this issue Sep 13, 2017 · 4 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope.

Comments

@hashibot
Copy link

This issue was originally opened by @JohnnyBoi888 as hashicorp/terraform#16081. It was migrated here as a result of the provider split. The original body of the issue is below.


Hi, is there a plan to feature support the new description field in security group egress/ingress rules (different from security group description itself)?

@hashibot hashibot added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 13, 2017
@atsushi-ishibashi
Copy link
Contributor

atsushi-ishibashi commented Sep 13, 2017

Would you like to support description fields for IpRanges, Ipv6Ranges, PrefixListIds, UserIdGroupPairs? According to the current codes, these are defined as List with string element.
So I think this update will become breaking-change...
http://docs.aws.amazon.com/cli/latest/reference/ec2/authorize-security-group-egress.html

@JohnnyBoi888
Copy link
Contributor

I believe the description (string) should be generic regardless of the type being IpRanges, Ipv6Ranges, PrefixListIds, etc. It's basically just a piggy-back field to individual SG rule entry:
screen shot 2017-09-12 at 7 56 04 pm

@Ninir
Copy link
Contributor

Ninir commented Sep 13, 2017

Hi folks!

There is another thread to keep track of this request here.

A PR has been PR for that also: #1587

Going to close this one to centralise discussions to the related threads.

Thanks!

@Ninir Ninir closed this as completed Sep 13, 2017
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

No branches or pull requests

4 participants