Gateway Load Balancer Support #16131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: #14601 Output from acceptance testing: ``` --- PASS: TestAccAWSLB_LoadBalancerType_Gateway (113.78s) ```
Reference: #14601 Output from acceptance testing: ``` --- PASS: TestAccAWSLBTargetGroup_Protocol_Geneve (29.03s) ```
…ument Output from acceptance testing: ``` --- PASS: TestAccAWSVpcEndpointService_GatewayLoadBalancerArns (209.75s) ```
…atewayLoadBalancer Reference: #14601 Output from acceptance testing: ``` --- PASS: TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer (272.58s) ```
Output from acceptance testing: ``` --- PASS: TestAccAWSRoute_VpcEndpointId (275.86s) ```
…id argument Output from acceptance testing: ``` --- PASS: TestAccAWSRouteTable_Route_VpcEndpointId (294.12s) ```
…ndpoint_id argument Output from acceptance testing: ``` --- PASS: TestAccAWSDefaultRouteTable_Route_VpcEndpointId (311.63s) ```
bflad
added
the
enhancement
ghost
added
size/XL
|
The original TC run (commercial) had some failures. I re-ran them and this is what I found: Subsequent local runs yielded (a34797c): GovCloud Commercial: |
|
The only potentially concerning test is the below, but its a pre-existing failure on the main branch, which I'll submit a separate fix. |
|
Configuration fix for |
YakDriver
approved these changes
Nov 11, 2020
|
This has been released in version 3.15.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
ewbankkit
added a commit
to ewbankkit/terraform-provider-aws
that referenced
this pull request
Nov 30, 2020
bflad
added a commit
that referenced
this pull request
Dec 7, 2020
…preparation for future fixes/enhancements (#14012) * r/aws_default_route_table: Rework 'TestAccAWSDefaultRouteTable_basic' and 'TestAccAWSDefaultRouteTable_disappears_Vpc'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDefaultRouteTable_basic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSDefaultRouteTable_basic -timeout 120m === RUN TestAccAWSDefaultRouteTable_basic === PAUSE TestAccAWSDefaultRouteTable_basic === CONT TestAccAWSDefaultRouteTable_basic --- PASS: TestAccAWSDefaultRouteTable_basic (53.01s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 53.064s $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDefaultRouteTable_disappears_Vpc' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSDefaultRouteTable_disappears_Vpc -timeout 120m === RUN TestAccAWSDefaultRouteTable_disappears_Vpc === PAUSE TestAccAWSDefaultRouteTable_disappears_Vpc === CONT TestAccAWSDefaultRouteTable_disappears_Vpc --- PASS: TestAccAWSDefaultRouteTable_disappears_Vpc (24.54s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 24.591s * r/aws_default_route_table: Rename 'TestAccAWSDefaultRouteTable_Route' to 'TestAccAWSDefaultRouteTable_Route_ConfigMode' to match r/aws_route_table. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDefaultRouteTable_Route_ConfigMode' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSDefaultRouteTable_Route_ConfigMode -timeout 120m === RUN TestAccAWSDefaultRouteTable_Route_ConfigMode === PAUSE TestAccAWSDefaultRouteTable_Route_ConfigMode === CONT TestAccAWSDefaultRouteTable_Route_ConfigMode --- PASS: TestAccAWSDefaultRouteTable_Route_ConfigMode (102.58s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 102.647s * r/aws_default_route_table: Rework 'TestAccAWSDefaultRouteTable_swap'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDefaultRouteTable_swap' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSDefaultRouteTable_swap -timeout 120m === RUN TestAccAWSDefaultRouteTable_swap === PAUSE TestAccAWSDefaultRouteTable_swap === CONT TestAccAWSDefaultRouteTable_swap --- PASS: TestAccAWSDefaultRouteTable_swap (109.41s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 109.499s * r/aws_default_route_table: 'TestAccAWSDefaultRouteTable_disappears_Vpc' -> 'TestAccAWSDefaultRouteTable_vpcDisappears'. * r/aws_default_route_table: Rework 'TestAccAWSDefaultRouteTable_ConditionalCidrBlock'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDefaultRouteTable_ConditionalCidrBlock' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSDefaultRouteTable_ConditionalCidrBlock -timeout 120m === RUN TestAccAWSDefaultRouteTable_ConditionalCidrBlock === PAUSE TestAccAWSDefaultRouteTable_ConditionalCidrBlock === CONT TestAccAWSDefaultRouteTable_ConditionalCidrBlock --- PASS: TestAccAWSDefaultRouteTable_ConditionalCidrBlock (79.63s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 80.192s * r/aws_default_route_table: Rename 'TestAccAWSDefaultRouteTable_vpc_endpoint' to 'TestAccAWSDefaultRouteTable_VpcEndpointAssociation'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDefaultRouteTable_VpcEndpointAssociation' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSDefaultRouteTable_VpcEndpointAssociation -timeout 120m === RUN TestAccAWSDefaultRouteTable_VpcEndpointAssociation === PAUSE TestAccAWSDefaultRouteTable_VpcEndpointAssociation === CONT TestAccAWSDefaultRouteTable_VpcEndpointAssociation --- PASS: TestAccAWSDefaultRouteTable_VpcEndpointAssociation (57.87s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 57.930s * r/aws_default_route_table: Rename 'TestAccAWSDefaultRouteTable_Route_TransitGatewayID' to 'TestAccAWSDefaultRouteTable_IPv4_To_TransitGateway'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDefaultRouteTable_IPv4_To_TransitGateway' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSDefaultRouteTable_IPv4_To_TransitGateway -timeout 120m === RUN TestAccAWSDefaultRouteTable_IPv4_To_TransitGateway === PAUSE TestAccAWSDefaultRouteTable_IPv4_To_TransitGateway === CONT TestAccAWSDefaultRouteTable_IPv4_To_TransitGateway --- PASS: TestAccAWSDefaultRouteTable_IPv4_To_TransitGateway (317.38s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 317.429s * r/aws_default_route_table: Add 'testAccCheckAWSDefaultRouteTableRoute'. * r/aws_default_route_table: Use 'testAccAvailableAZsNoOptInExcludeConfig'. * Use 'testAccAvailableAZsNoOptInDefaultExcludeConfig'. * r/aws_default_route_table: Add acceptance tests from #16131. * Rename 'TestAccAWSDefaultRouteTable_Route_VpcEndpointId' to 'TestAccAWSDefaultRouteTable_IPv4_To_VpcEndpoint'. * r/aws_default_route_table: Missing commit from rebase. * Update aws/resource_aws_default_route_table_test.go Co-authored-by: Brian Flad <bflad417@gmail.com> Co-authored-by: Brian Flad <bflad417@gmail.com>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Reference: #14601
Closes #16129
Release note for CHANGELOG:
Output from acceptance testing: