r/aws_storagegateway_smb_file_share: Add file_share_name argument

[gazoakley]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15937

Release note for CHANGELOG:

* resource/aws_storagegateway_smb_file_share: Add `file_share_name` argument ([#16008](https://github.com/hashicorp/terraform-provider-aws/issues/16008))

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSStorageGatewaySmbFileShare_FileShareName'  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSStorageGatewaySmbFileShare_FileShareName -timeout 120m
=== RUN   TestAccAWSStorageGatewaySmbFileShare_FileShareName
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_FileShareName
=== CONT  TestAccAWSStorageGatewaySmbFileShare_FileShareName
--- PASS: TestAccAWSStorageGatewaySmbFileShare_FileShareName (349.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	351.306s

$ make testacc TESTARGS='-run=TestAccAWSStorageGatewaySmbFileShare_Authentication_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSStorageGatewaySmbFileShare_Authentication_ -timeout 120m
=== RUN   TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
=== RUN   TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess
=== CONT  TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
=== CONT  TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess (308.84s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory (797.87s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	799.389s

[DrFaust92]

LGTM

--- PASS: TestAccAWSStorageGatewaySmbFileShare_ObjectACL (562.81s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled (568.27s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_disappears (300.31s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory (904.45s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_caseSensitivity (522.30s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_AdminUserList (1177.97s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted (372.34s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_cacheAttributes (555.98s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_audit (404.08s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn (559.84s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_FileShareName (410.63s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Tags (459.65s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_RequesterPays (460.70s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_smb_acl (1105.53s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ReadOnly (409.81s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess (319.46s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ValidUserList (1113.33s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass (467.41s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_InvalidUserList (1203.27s)

[breathingdust]

LGTM 🚀 Thanks @gazoakley for the implementation!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSStorageGatewaySmbFileShare_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSStorageGatewaySmbFileShare_ -timeout 120m
=== RUN   TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
=== RUN   TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess
=== RUN   TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass
=== RUN   TestAccAWSStorageGatewaySmbFileShare_FileShareName
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_FileShareName
=== RUN   TestAccAWSStorageGatewaySmbFileShare_Tags
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_Tags
=== RUN   TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled
=== RUN   TestAccAWSStorageGatewaySmbFileShare_InvalidUserList
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_InvalidUserList
=== RUN   TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted
=== RUN   TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn
=== RUN   TestAccAWSStorageGatewaySmbFileShare_ObjectACL
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_ObjectACL
=== RUN   TestAccAWSStorageGatewaySmbFileShare_ReadOnly
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_ReadOnly
=== RUN   TestAccAWSStorageGatewaySmbFileShare_RequesterPays
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_RequesterPays
=== RUN   TestAccAWSStorageGatewaySmbFileShare_ValidUserList
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_ValidUserList
=== RUN   TestAccAWSStorageGatewaySmbFileShare_smb_acl
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_smb_acl
=== RUN   TestAccAWSStorageGatewaySmbFileShare_audit
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_audit
=== RUN   TestAccAWSStorageGatewaySmbFileShare_cacheAttributes
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_cacheAttributes
=== RUN   TestAccAWSStorageGatewaySmbFileShare_caseSensitivity
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_caseSensitivity
=== RUN   TestAccAWSStorageGatewaySmbFileShare_disappears
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_disappears
=== RUN   TestAccAWSStorageGatewaySmbFileShare_AdminUserList
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_AdminUserList
=== CONT  TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory
=== CONT  TestAccAWSStorageGatewaySmbFileShare_ReadOnly
=== CONT  TestAccAWSStorageGatewaySmbFileShare_AdminUserList
=== CONT  TestAccAWSStorageGatewaySmbFileShare_disappears
=== CONT  TestAccAWSStorageGatewaySmbFileShare_caseSensitivity
=== CONT  TestAccAWSStorageGatewaySmbFileShare_cacheAttributes
=== CONT  TestAccAWSStorageGatewaySmbFileShare_audit
=== CONT  TestAccAWSStorageGatewaySmbFileShare_smb_acl
=== CONT  TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled
=== CONT  TestAccAWSStorageGatewaySmbFileShare_InvalidUserList
=== CONT  TestAccAWSStorageGatewaySmbFileShare_RequesterPays
=== CONT  TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn
=== CONT  TestAccAWSStorageGatewaySmbFileShare_ObjectACL
=== CONT  TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted
=== CONT  TestAccAWSStorageGatewaySmbFileShare_FileShareName
=== CONT  TestAccAWSStorageGatewaySmbFileShare_Tags
=== CONT  TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass
=== CONT  TestAccAWSStorageGatewaySmbFileShare_ValidUserList
=== CONT  TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess
2020/11/12 16:27:56 [DEBUG] Reading SSM Parameter: {
  Name: "/aws/service/storagegateway/ami/FILE_S3/latest",
  WithDecryption: true
}
2020/11/12 16:27:59 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/12 16:27:59 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/12 16:28:01 [DEBUG] Trying to get account information via sts:GetCallerIdentity
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess (230.71s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted (239.79s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_disappears (246.47s)
2020/11/12 16:32:34 [TRACE] Waiting 10s before next try
--- PASS: TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled (290.10s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ObjectACL (291.23s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Tags (296.35s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_FileShareName (296.41s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ReadOnly (315.63s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_RequesterPays (335.63s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn (360.34s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_cacheAttributes (392.04s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_caseSensitivity (396.84s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_audit (399.81s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass (419.99s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory (813.21s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_AdminUserList (970.23s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_InvalidUserList (977.18s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ValidUserList (1042.87s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_smb_acl (1061.14s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1062.714s

[breathingdust]

Note that I am seeing test failures in GovCloud for this resource due to Simple AD not being available in that region. This was not introduced by that PR. I have created an issue here to track #16172 and resolve.

[ghost]

This has been released in version 3.16.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!