Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_apigatewayv2_integration timeout_milliseconds input should have a ceiling of 30,000 #16002

Closed
tscully49 opened this issue Nov 3, 2020 · 5 comments · Fixed by #16017
Closed
Assignees
Labels
bug Addresses a defect in current functionality. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service.
Milestone

Comments

@tscully49
Copy link

tscully49 commented Nov 3, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Terraform v0.12.26
+ provider.aws v2.70.0
(also tested with AWS provider version 3.13.0)

Affected Resource(s)

  • aws_apigatewayv2_integration resource

Terraform Configuration Files

resource "aws_apigatewayv2_integration" "my_lambda" {
  api_id           = aws_apigatewayv2_api.api_gateway.id
  integration_type = "AWS_PROXY"

  connection_type              = "INTERNET"
  integration_method         = "POST"
  payload_format_version  = "2.0"
  timeout_milliseconds      = 30000
  integration_uri                  = aws_lambda_function.lamba.arn
}

Expected Behavior

Should be allowed to set the input timeout_milliseconds to a value up to 30000 per the documentation https://docs.aws.amazon.com/apigateway/latest/developerguide/limits.html.

Actual Behavior

The provider throws an error if a value above 29000 is given.

Important Factoids

Documentation here (https://docs.aws.amazon.com/apigateway/latest/developerguide/limits.html) claims that the timeout for integrations is 30 seconds.

References

@ghost ghost added the service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. label Nov 3, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 3, 2020
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 4, 2020
@ewbankkit ewbankkit self-assigned this Nov 4, 2020
@ewbankkit
Copy link
Contributor

ewbankkit commented Nov 4, 2020

@tscully49 Thanks for raising this issue.
You are correct, the default and maximum timeouts are different for WebSocket and HTTP APIs:

Custom timeout between 50 and 29,000 milliseconds for WebSocket APIs and between 50 and 30,000 milliseconds for HTTP APIs. The default timeout is 29 seconds for WebSocket APIs and 30 seconds for HTTP APIs.

I'll address this.

@ghost
Copy link

ghost commented Nov 6, 2020

This has been released in version 3.14.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@warrenstephens
Copy link

Looks like I am seeing the 29000 limit in provider version 3.15.

My integration is currently deployed with 30000, and terraform wants to change it to 29000.

@ewbankkit
Copy link
Contributor

@warrenstephens Can you paste the relevant configuration?

@ghost
Copy link

ghost commented Dec 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service.
Projects
None yet
4 participants