Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/glue_classifier - quote_symbol fix optional #15948

Merged
merged 4 commits into from
Nov 4, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13058
Relates #13826

Release note for CHANGELOG:

resource_aws_glue_classifier - fix `quote_symbol` being optional

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueClassifier_'
--- PASS: TestAccAWSGlueClassifier_disappears (25.94s)
--- PASS: TestAccAWSGlueClassifier_XmlClassifier (58.44s)
--- PASS: TestAccAWSGlueClassifier_GrokClassifier_CustomPatterns (58.67s)
--- PASS: TestAccAWSGlueClassifier_CsvClassifier_quoteSymbol (58.79s)
--- PASS: TestAccAWSGlueClassifier_GrokClassifier (58.83s)
--- PASS: TestAccAWSGlueClassifier_JsonClassifier (59.26s)
--- PASS: TestAccAWSGlueClassifier_CsvClassifier (60.07s)
--- PASS: TestAccAWSGlueClassifier_TypeChange (109.12s)
...

@DrFaust92 DrFaust92 requested a review from a team October 30, 2020 21:57
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 30, 2020
@DrFaust92 DrFaust92 added the bug Addresses a defect in current functionality. label Oct 30, 2020
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueClassifier_' ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 3 -run=TestAccAWSGlueClassifier_ -timeout 120m
=== RUN   TestAccAWSGlueClassifier_CsvClassifier
=== PAUSE TestAccAWSGlueClassifier_CsvClassifier
=== RUN   TestAccAWSGlueClassifier_CsvClassifier_quoteSymbol
=== PAUSE TestAccAWSGlueClassifier_CsvClassifier_quoteSymbol
=== RUN   TestAccAWSGlueClassifier_GrokClassifier
=== PAUSE TestAccAWSGlueClassifier_GrokClassifier
=== RUN   TestAccAWSGlueClassifier_GrokClassifier_CustomPatterns
=== PAUSE TestAccAWSGlueClassifier_GrokClassifier_CustomPatterns
=== RUN   TestAccAWSGlueClassifier_JsonClassifier
=== PAUSE TestAccAWSGlueClassifier_JsonClassifier
=== RUN   TestAccAWSGlueClassifier_TypeChange
=== PAUSE TestAccAWSGlueClassifier_TypeChange
=== RUN   TestAccAWSGlueClassifier_XmlClassifier
=== PAUSE TestAccAWSGlueClassifier_XmlClassifier
=== RUN   TestAccAWSGlueClassifier_disappears
=== PAUSE TestAccAWSGlueClassifier_disappears
=== CONT  TestAccAWSGlueClassifier_CsvClassifier
=== CONT  TestAccAWSGlueClassifier_TypeChange
=== CONT  TestAccAWSGlueClassifier_disappears
--- PASS: TestAccAWSGlueClassifier_disappears (15.66s)
=== CONT  TestAccAWSGlueClassifier_XmlClassifier
--- PASS: TestAccAWSGlueClassifier_CsvClassifier (35.96s)
=== CONT  TestAccAWSGlueClassifier_GrokClassifier_CustomPatterns
--- PASS: TestAccAWSGlueClassifier_XmlClassifier (34.07s)
=== CONT  TestAccAWSGlueClassifier_JsonClassifier
--- PASS: TestAccAWSGlueClassifier_TypeChange (65.15s)
=== CONT  TestAccAWSGlueClassifier_GrokClassifier
--- PASS: TestAccAWSGlueClassifier_GrokClassifier_CustomPatterns (34.96s)
=== CONT  TestAccAWSGlueClassifier_CsvClassifier_quoteSymbol
--- PASS: TestAccAWSGlueClassifier_JsonClassifier (39.16s)
--- PASS: TestAccAWSGlueClassifier_GrokClassifier (37.39s)
--- PASS: TestAccAWSGlueClassifier_CsvClassifier_quoteSymbol (35.89s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	106.877s

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueClassifier_' ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 3 -run=TestAccAWSGlueClassifier_ -timeout 120m
=== RUN   TestAccAWSGlueClassifier_CsvClassifier
=== PAUSE TestAccAWSGlueClassifier_CsvClassifier
=== RUN   TestAccAWSGlueClassifier_CsvClassifier_quoteSymbol
=== PAUSE TestAccAWSGlueClassifier_CsvClassifier_quoteSymbol
=== RUN   TestAccAWSGlueClassifier_GrokClassifier
=== PAUSE TestAccAWSGlueClassifier_GrokClassifier
=== RUN   TestAccAWSGlueClassifier_GrokClassifier_CustomPatterns
=== PAUSE TestAccAWSGlueClassifier_GrokClassifier_CustomPatterns
=== RUN   TestAccAWSGlueClassifier_JsonClassifier
=== PAUSE TestAccAWSGlueClassifier_JsonClassifier
=== RUN   TestAccAWSGlueClassifier_TypeChange
=== PAUSE TestAccAWSGlueClassifier_TypeChange
=== RUN   TestAccAWSGlueClassifier_XmlClassifier
=== PAUSE TestAccAWSGlueClassifier_XmlClassifier
=== RUN   TestAccAWSGlueClassifier_disappears
=== PAUSE TestAccAWSGlueClassifier_disappears
=== CONT  TestAccAWSGlueClassifier_CsvClassifier
=== CONT  TestAccAWSGlueClassifier_TypeChange
=== CONT  TestAccAWSGlueClassifier_disappears
--- PASS: TestAccAWSGlueClassifier_disappears (11.47s)
=== CONT  TestAccAWSGlueClassifier_XmlClassifier
--- PASS: TestAccAWSGlueClassifier_CsvClassifier (26.88s)
=== CONT  TestAccAWSGlueClassifier_GrokClassifier_CustomPatterns
--- PASS: TestAccAWSGlueClassifier_XmlClassifier (30.14s)
=== CONT  TestAccAWSGlueClassifier_JsonClassifier
--- PASS: TestAccAWSGlueClassifier_TypeChange (47.58s)
=== CONT  TestAccAWSGlueClassifier_GrokClassifier
--- PASS: TestAccAWSGlueClassifier_GrokClassifier_CustomPatterns (30.76s)
=== CONT  TestAccAWSGlueClassifier_CsvClassifier_quoteSymbol
--- PASS: TestAccAWSGlueClassifier_JsonClassifier (30.36s)
--- PASS: TestAccAWSGlueClassifier_GrokClassifier (33.02s)
--- PASS: TestAccAWSGlueClassifier_CsvClassifier_quoteSymbol (27.20s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	86.447s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueClassifier_' ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 3 -run=TestAccAWSGlueClassifier_ -timeout 120m
=== RUN   TestAccAWSGlueClassifier_CsvClassifier
=== PAUSE TestAccAWSGlueClassifier_CsvClassifier
=== RUN   TestAccAWSGlueClassifier_CsvClassifier_quoteSymbol
=== PAUSE TestAccAWSGlueClassifier_CsvClassifier_quoteSymbol
=== RUN   TestAccAWSGlueClassifier_GrokClassifier
=== PAUSE TestAccAWSGlueClassifier_GrokClassifier
=== RUN   TestAccAWSGlueClassifier_GrokClassifier_CustomPatterns
=== PAUSE TestAccAWSGlueClassifier_GrokClassifier_CustomPatterns
=== RUN   TestAccAWSGlueClassifier_JsonClassifier
=== PAUSE TestAccAWSGlueClassifier_JsonClassifier
=== RUN   TestAccAWSGlueClassifier_TypeChange
=== PAUSE TestAccAWSGlueClassifier_TypeChange
=== RUN   TestAccAWSGlueClassifier_XmlClassifier
=== PAUSE TestAccAWSGlueClassifier_XmlClassifier
=== RUN   TestAccAWSGlueClassifier_disappears
=== PAUSE TestAccAWSGlueClassifier_disappears
=== CONT  TestAccAWSGlueClassifier_CsvClassifier
=== CONT  TestAccAWSGlueClassifier_TypeChange
=== CONT  TestAccAWSGlueClassifier_disappears
--- PASS: TestAccAWSGlueClassifier_disappears (7.81s)
=== CONT  TestAccAWSGlueClassifier_XmlClassifier
--- PASS: TestAccAWSGlueClassifier_CsvClassifier (18.23s)
=== CONT  TestAccAWSGlueClassifier_JsonClassifier
--- PASS: TestAccAWSGlueClassifier_XmlClassifier (17.30s)
=== CONT  TestAccAWSGlueClassifier_GrokClassifier_CustomPatterns
--- PASS: TestAccAWSGlueClassifier_JsonClassifier (17.05s)
=== CONT  TestAccAWSGlueClassifier_CsvClassifier_quoteSymbol
--- PASS: TestAccAWSGlueClassifier_TypeChange (37.30s)
=== CONT  TestAccAWSGlueClassifier_GrokClassifier
--- PASS: TestAccAWSGlueClassifier_GrokClassifier_CustomPatterns (21.10s)
--- PASS: TestAccAWSGlueClassifier_CsvClassifier_quoteSymbol (18.56s)
--- PASS: TestAccAWSGlueClassifier_GrokClassifier (19.51s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	58.413s

@breathingdust breathingdust added this to the v3.14.0 milestone Nov 4, 2020
@breathingdust breathingdust merged commit ea4b429 into hashicorp:master Nov 4, 2020
breathingdust added a commit that referenced this pull request Nov 4, 2020
@ghost
Copy link

ghost commented Nov 6, 2020

This has been released in version 3.14.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 5, 2020
@DrFaust92 DrFaust92 deleted the r/glue_classifier_csv branch April 15, 2021 10:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_glue_classifier - seems to require QuoteSymbol for CSV
3 participants