Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_appmesh_virtual_gateway: New resource #15611

Merged
merged 2 commits into from
Oct 14, 2020
Merged

r/aws_appmesh_virtual_gateway: New resource #15611

merged 2 commits into from
Oct 14, 2020

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates: #14169.

Release note for CHANGELOG:

resource/aws_appmesh_virtual_gateway: New resource

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualGateway'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualGateway -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/tls
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/backendDefaults
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/disappears
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/listenerHealthChecks
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/logging
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/tags
--- PASS: TestAccAWSAppmesh_serial (281.31s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualGateway (281.31s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/tls (86.76s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/backendDefaults (35.74s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/basic (20.41s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/disappears (17.03s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/listenerHealthChecks (35.32s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/logging (35.34s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/tags (50.70s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	281.382s

@ewbankkit
r/aws_appmesh_virtual_gateway: New resource.
e028723 
Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualGateway'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualGateway -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/tls
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/backendDefaults
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/disappears
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/listenerHealthChecks
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/logging
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/tags
--- PASS: TestAccAWSAppmesh_serial (281.31s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualGateway (281.31s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/tls (86.76s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/backendDefaults (35.74s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/basic (20.41s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/disappears (17.03s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/listenerHealthChecks (35.32s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/logging (35.34s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/tags (50.70s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	281.382s
@ewbankkit ewbankkit requested a review from a team October 12, 2020 22:23
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/appmesh Issues and PRs that pertain to the appmesh service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 12, 2020
DrFaust92
DrFaust92 approved these changes Oct 13, 2020
View reviewed changes
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

--- PASS: TestAccAWSAppmesh_serial (612.83s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualGateway (612.83s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/basic (43.90s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/disappears (37.04s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/listenerHealthChecks (79.35s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/logging (79.26s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/tags (109.99s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/tls (183.63s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/backendDefaults (79.66s)

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @ewbankkit!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualGateway'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualGateway -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/listenerHealthChecks
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/logging
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/tls
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/backendDefaults
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualGateway/disappears
--- PASS: TestAccAWSAppmesh_serial (222.64s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualGateway (222.64s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/listenerHealthChecks (28.03s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/logging (27.07s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/tags (39.63s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/tls (68.75s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/backendDefaults (29.33s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/basic (16.47s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/disappears (13.36s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	224.195s

@breathingdust breathingdust added this to the v3.11.0 milestone Oct 14, 2020
@breathingdust breathingdust merged commit a5f58ee into hashicorp:master Oct 14, 2020
breathingdust added a commit that referenced this pull request Oct 14, 2020
@breathingdust
Update CHANGELOG.md for #15611
f168458
@ewbankkit ewbankkit deleted the f-aws_appmesh_virtual_gateway branch October 14, 2020 12:06
@ghost
Copy link

ghost commented Oct 15, 2020

This has been released in version 3.11.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DrFaust92 DrFaust92 DrFaust92 approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/appmesh Issues and PRs that pertain to the appmesh service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ewbankkit @breathingdust @DrFaust92