Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F/aws elasticache cluster final snapshot #15592

Merged
merged 5 commits into from
Jan 12, 2021
Merged

F/aws elasticache cluster final snapshot #15592

merged 5 commits into from
Jan 12, 2021

Conversation

nikhil-goenka
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #15483

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@nikhil-goenka nikhil-goenka requested a review from a team October 10, 2020 11:26
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/elasticache Issues and PRs that pertain to the elasticache service. labels Oct 10, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 10, 2020
@ghost ghost added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Oct 10, 2020
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Oct 10, 2020
@gdavison gdavison self-assigned this Jan 8, 2021
gdavison added a commit that referenced this pull request Jan 12, 2021
@gdavison
Merge pull request #15592 from nikhil-goenka:f/aws_elasticache_cluste…
6f38eb6 
…r-final-snapshot
gdavison added a commit that referenced this pull request Jan 12, 2021
@gdavison
Update CHANGELOG for #15592
7eb6172
@gdavison gdavison merged commit 909f0c3 into hashicorp:master Jan 12, 2021
gdavison
gdavison approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @nikhil-goenka 🚀

@gdavison gdavison removed the needs-triage Waiting for first response or review from a maintainer. label Jan 12, 2021
@ghost
Copy link

ghost commented Feb 12, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees

@gdavison gdavison

Labels
documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support final snapshots when deleting ElastiCache Instances
2 participants
@nikhil-goenka @gdavison