resource/aws_s3_bucket_analytics_configuration: Check resource.TimeoutError on deletion

[bflad]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #12985

Release note for CHANGELOG:

* resource/aws_s3_bucket_analytics_configuration: Prevent unexpected timeout error on deletion due to API throttling

Output from acceptance testing (test failure present on main branch):

--- FAIL: TestAccAWSS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_Empty (2.96s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_Empty (3.02s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_basic (36.11s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_Full (38.05s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_Default (39.12s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_removed (58.44s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_SingleTag (61.76s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_Remove (62.27s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_PrefixAndTags (64.30s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_MultipleTags (64.43s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_Prefix (64.54s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_updateBasic (102.92s)

[YakDriver]

Would it be possible and/or worthwhile to add an acceptance test that consistently fails without the fix?

[bflad]

@YakDriver I'm not sure how to ensure the API or network layer always throttles requests past the timeout for that type of test beyond generating a ton of concurrent test resources. Sometimes this throttling occurs when the service team is trying to fix backend issues or the Terraform executor is having trouble opening network sockets in highly concurrent runs, which is not reproducible without mocking the API and/or network stack which we have long avoided due to the complexity and maintainability that framework would require over time. It was decided awhile ago that the most pragmatic approach to these would be to fix the issue from a code perspective, document the behavior in the Contributing Guide, and for maintainers to be on the lookout for it. Now we can have linters doing the hard work.

[YakDriver]

LGTM 💯

--- PASS: TestFlattenS3StorageClassAnalysis (0.06s)
--- PASS: TestFlattenS3AnalyticsFilter (0.49s)
--- PASS: TestExpandS3AnalyticsFilter (0.54s)
--- PASS: TestExpandS3StorageClassAnalysis (0.63s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_Empty (5.57s)
--- FAIL: TestAccAWSS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_Empty (6.07s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_Default (42.24s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_basic (44.71s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_Full (45.15s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_removed (65.34s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_PrefixAndTags (67.00s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_Prefix (67.58s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_MultipleTags (67.76s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_Remove (68.06s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_SingleTag (70.15s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_updateBasic (82.68s)

Failure appears transient and unrelated:

TestAccAWSS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_Empty: resource_aws_s3_bucket_analytics_configuration_test.go:361: Step 1/1, expected an error with pattern, no match on: Error running pre-apply refresh: 2020/10/07 14:45:47 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0
        
        Error: Required attribute is not set
        
          on config359220260/terraform_plugin_test.tf line 6, in resource "aws_s3_bucket_analytics_configuration" "test":
           6:   storage_class_analysis {   
--- FAIL: TestAccAWSS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_Empty (5.89s)

[ghost]

This has been released in version 3.10.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!