Add TLS Config to api gateway integration

[tmcgahern]

Co-authored-by: jake-mcdermott mail@jake.ie

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15492

The change was based on a similar tls_config block in the API gateway V2 integration here:
https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/resource_aws_apigatewayv2_integration.go#L132

Release note for CHANGELOG:

resource/aws_api_gateway_integration: Add `tls_config` block to support `insecureSkipVerification` 

Output from acceptance testing:

make testacc TESTARGS='-run=TestAccAWSAPIGatewayIntegration'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayIntegration -timeout 120m
=== RUN   TestAccAWSAPIGatewayIntegrationResponse_basic
=== PAUSE TestAccAWSAPIGatewayIntegrationResponse_basic
=== RUN   TestAccAWSAPIGatewayIntegrationResponse_disappears
=== PAUSE TestAccAWSAPIGatewayIntegrationResponse_disappears
=== RUN   TestAccAWSAPIGatewayIntegration_basic
=== PAUSE TestAccAWSAPIGatewayIntegration_basic
=== RUN   TestAccAWSAPIGatewayIntegration_contentHandling
=== PAUSE TestAccAWSAPIGatewayIntegration_contentHandling
=== RUN   TestAccAWSAPIGatewayIntegration_cache_key_parameters
=== PAUSE TestAccAWSAPIGatewayIntegration_cache_key_parameters
=== RUN   TestAccAWSAPIGatewayIntegration_integrationType
=== PAUSE TestAccAWSAPIGatewayIntegration_integrationType
=== RUN   TestAccAWSAPIGatewayIntegration_disappears
=== PAUSE TestAccAWSAPIGatewayIntegration_disappears
=== CONT  TestAccAWSAPIGatewayIntegrationResponse_basic
=== CONT  TestAccAWSAPIGatewayIntegration_cache_key_parameters
=== CONT  TestAccAWSAPIGatewayIntegration_disappears
=== CONT  TestAccAWSAPIGatewayIntegration_basic
=== CONT  TestAccAWSAPIGatewayIntegration_contentHandling
=== CONT  TestAccAWSAPIGatewayIntegration_integrationType
=== CONT  TestAccAWSAPIGatewayIntegrationResponse_disappears
=== CONT  TestAccAWSAPIGatewayIntegration_disappears
    resource_aws_api_gateway_integration_test.go:296: [INFO] Got non-empty plan, as expected
=== CONT  TestAccAWSAPIGatewayIntegrationResponse_disappears
    resource_aws_api_gateway_integration_response_test.go:67: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSAPIGatewayIntegration_disappears (128.41s)
--- PASS: TestAccAWSAPIGatewayIntegrationResponse_disappears (132.04s)
--- PASS: TestAccAWSAPIGatewayIntegration_cache_key_parameters (143.51s)
--- PASS: TestAccAWSAPIGatewayIntegrationResponse_basic (220.33s)
2020/10/05 20:01:55 [INFO] Successfully derived credentials from session
2020/10/05 20:01:55 [INFO] AWS Auth provider used: "AssumeRoleProvider"
--- PASS: TestAccAWSAPIGatewayIntegration_contentHandling (282.20s)
--- PASS: TestAccAWSAPIGatewayIntegration_basic (374.41s)
--- PASS: TestAccAWSAPIGatewayIntegration_integrationType (917.51s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       920.219s```

[tmcgahern]

This test is the same as Line 259 so instead of creating another test I've replaced the duplicate with the new test

[bflad]

If I recall correctly, the update back to INTERNET was an intentional update test. In general, the maintainers prefer if existing testing is not touched to ensure regressions are covered.

[bflad]

Thank you for submitting this, @tmcgahern. Overall it looks really good and we will be pulling this in with just some minor testing updates.

[bflad]

If I recall correctly, the update back to INTERNET was an intentional update test. In general, the maintainers prefer if existing testing is not touched to ensure regressions are covered.

[bflad]

Will move this to its own acceptance test and make the insecure_skip_verification a boolean function parameter so we can easily verify updates between true/false.

[ghost]

This has been released in version 3.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!