-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurable timeouts to workspaces #15479
Add configurable timeouts to workspaces #15479
Conversation
e3de49c
to
da76ff2
Compare
da76ff2
to
be37ff4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsWorkspacesWorkspace_timeout\|TestAccAwsWorkspacesWorkspace_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsWorkspacesWorkspace_timeout\|TestAccAwsWorkspacesWorkspace_basic -timeout 120m
go: downloading github.com/aws/aws-sdk-go v1.35.2
go: downloading github.com/jmespath/go-jmespath v0.4.0
=== RUN TestAccAwsWorkspacesWorkspace_basic
=== PAUSE TestAccAwsWorkspacesWorkspace_basic
=== RUN TestAccAwsWorkspacesWorkspace_timeout
=== PAUSE TestAccAwsWorkspacesWorkspace_timeout
=== CONT TestAccAwsWorkspacesWorkspace_basic
=== CONT TestAccAwsWorkspacesWorkspace_timeout
--- PASS: TestAccAwsWorkspacesWorkspace_timeout (1613.94s)
--- PASS: TestAccAwsWorkspacesWorkspace_basic (1667.64s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 1667.682s
be37ff4
to
4224b7b
Compare
636765a
to
6b8b08a
Compare
082b00d
to
5f6cce0
Compare
LGTM 🚀 Thanks @Tensho for the contribution! Verified Acceptance Tests in Commercial (us-west-2) make testacc TEST=./aws TESTARGS='-run=TestAccAwsWorkspacesWorkspace_timeout\|TestAccAwsWorkspacesWorkspace_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsWorkspacesWorkspace_timeout\|TestAccAwsWorkspacesWorkspace_basic -timeout 120m
=== RUN TestAccAwsWorkspacesWorkspace_basic
=== PAUSE TestAccAwsWorkspacesWorkspace_basic
=== RUN TestAccAwsWorkspacesWorkspace_timeout
=== PAUSE TestAccAwsWorkspacesWorkspace_timeout
=== CONT TestAccAwsWorkspacesWorkspace_basic
=== CONT TestAccAwsWorkspacesWorkspace_timeout
--- PASS: TestAccAwsWorkspacesWorkspace_basic (1794.27s)
--- PASS: TestAccAwsWorkspacesWorkspace_timeout (1989.67s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 1991.094s |
This has been released in version 3.15.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Relates to #13598
Release note for CHANGELOG:
Acceptance Tests