Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable timeouts to workspaces #15479

Merged

Conversation

Tensho
Copy link
Contributor

@Tensho Tensho commented Oct 5, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates to #13598

Release note for CHANGELOG:

Configurable workspaces timeouts

Acceptance Tests

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsWorkspacesWorkspace_timeout'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsWorkspacesWorkspace_timeout -timeout 120m
=== RUN   TestAccAwsWorkspacesWorkspace_timeout
=== PAUSE TestAccAwsWorkspacesWorkspace_timeout
=== CONT  TestAccAwsWorkspacesWorkspace_timeout
--- PASS: TestAccAwsWorkspacesWorkspace_timeout (1019.27s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1023.255s

@Tensho Tensho requested a review from a team October 5, 2020 09:01
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/workspaces Issues and PRs that pertain to the workspaces service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 5, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 5, 2020
@Tensho Tensho force-pushed the workspaces-configurable-timeouts branch from e3de49c to da76ff2 Compare October 5, 2020 09:04
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Oct 5, 2020
@Tensho Tensho force-pushed the workspaces-configurable-timeouts branch from da76ff2 to be37ff4 Compare October 5, 2020 09:16
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsWorkspacesWorkspace_timeout\|TestAccAwsWorkspacesWorkspace_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsWorkspacesWorkspace_timeout\|TestAccAwsWorkspacesWorkspace_basic -timeout 120m
go: downloading github.com/aws/aws-sdk-go v1.35.2
go: downloading github.com/jmespath/go-jmespath v0.4.0
=== RUN   TestAccAwsWorkspacesWorkspace_basic
=== PAUSE TestAccAwsWorkspacesWorkspace_basic
=== RUN   TestAccAwsWorkspacesWorkspace_timeout
=== PAUSE TestAccAwsWorkspacesWorkspace_timeout
=== CONT  TestAccAwsWorkspacesWorkspace_basic
=== CONT  TestAccAwsWorkspacesWorkspace_timeout
--- PASS: TestAccAwsWorkspacesWorkspace_timeout (1613.94s)
--- PASS: TestAccAwsWorkspacesWorkspace_basic (1667.64s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1667.682s

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Oct 5, 2020
@Tensho Tensho force-pushed the workspaces-configurable-timeouts branch from be37ff4 to 4224b7b Compare November 9, 2020 10:05
@Tensho Tensho requested a review from a team as a code owner November 9, 2020 10:05
@Tensho Tensho force-pushed the workspaces-configurable-timeouts branch from 636765a to 6b8b08a Compare November 9, 2020 13:48
@Tensho Tensho force-pushed the workspaces-configurable-timeouts branch from 082b00d to 5f6cce0 Compare November 9, 2020 16:00
@breathingdust
Copy link
Member

LGTM 🚀 Thanks @Tensho for the contribution!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAwsWorkspacesWorkspace_timeout\|TestAccAwsWorkspacesWorkspace_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsWorkspacesWorkspace_timeout\|TestAccAwsWorkspacesWorkspace_basic -timeout 120m
=== RUN   TestAccAwsWorkspacesWorkspace_basic
=== PAUSE TestAccAwsWorkspacesWorkspace_basic
=== RUN   TestAccAwsWorkspacesWorkspace_timeout
=== PAUSE TestAccAwsWorkspacesWorkspace_timeout
=== CONT  TestAccAwsWorkspacesWorkspace_basic
=== CONT  TestAccAwsWorkspacesWorkspace_timeout
--- PASS: TestAccAwsWorkspacesWorkspace_basic (1794.27s)
--- PASS: TestAccAwsWorkspacesWorkspace_timeout (1989.67s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1991.094s

@breathingdust breathingdust added this to the v3.15.0 milestone Nov 9, 2020
@breathingdust breathingdust merged commit c718eeb into hashicorp:master Nov 9, 2020
breathingdust added a commit that referenced this pull request Nov 9, 2020
@Tensho Tensho deleted the workspaces-configurable-timeouts branch November 9, 2020 17:01
@ghost
Copy link

ghost commented Nov 12, 2020

This has been released in version 3.15.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/workspaces Issues and PRs that pertain to the workspaces service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants