-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service/dms: add data source for dms_replication_instance #15406
Conversation
63ba417
to
a854cfb
Compare
Sorry, I know it's only a single data source, instead of all of them for DMS. I'm fairly unfamiliar with Go, and I wanted to keep the pull request as small as possible to make reviewing easier. |
Nice work @snypelife |
What's blocking this? This is a pretty significant gap and we'd love for it to be closed. |
Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding. Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author. For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000. For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide. |
f3ca86d
to
5a6d073
Compare
5a6d073
to
caa4bd5
Compare
caa4bd5
to
c2e3d53
Compare
Hey @zhelding thank you for the heads up on the refactor that went in. I've updated my fork and rebased the PR to get it to a merge-able state. |
c2e3d53
to
fe08697
Compare
Heyo! Any uptake on this by any chance? I know it's probably not the most requested feature, but it's intentionally small to make review and acceptance (hopefully) easier. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing! 🚀
|
🎉 Thanks for merging this @nam054! |
This functionality has been released in v4.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates to #12713
Release note for CHANGELOG:
Output from acceptance testing: