Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_aws_elasticache_replication_group: Add arn attribute #15348

Conversation

angelabad
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15267

Release note for CHANGELOG:

resource_aws_elasticache_replication_group: Add arn attribute

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSElasticacheReplicationGroup_vpc'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSElasticacheReplicationGroup_vpc -timeout 120m
=== RUN   TestAccAWSElasticacheReplicationGroup_vpc
=== PAUSE TestAccAWSElasticacheReplicationGroup_vpc
=== CONT  TestAccAWSElasticacheReplicationGroup_vpc
--- PASS: TestAccAWSElasticacheReplicationGroup_vpc (601.58s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	601.621s
...

@angelabad angelabad requested a review from a team September 25, 2020 06:21
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. labels Sep 25, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 25, 2020
@gdavison gdavison self-assigned this Jan 15, 2021
@gdavison gdavison removed the needs-triage Waiting for first response or review from a maintainer. label Jan 15, 2021
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @angelabad. LGTM 🚀

--- PASS: TestAccAWSElasticacheReplicationGroup_basic (859.50s)
--- PASS: TestAccDataSourceAwsElasticacheReplicationGroup_basic (937.03s)

gdavison added a commit that referenced this pull request Jan 15, 2021
@gdavison gdavison merged commit 29df946 into hashicorp:master Jan 15, 2021
gdavison added a commit that referenced this pull request Jan 16, 2021
@angelabad angelabad deleted the b-fix-aws_elasticache_replication_group-arn branch January 17, 2021 08:34
gdavison added a commit that referenced this pull request Jan 21, 2021
@ghost
Copy link

ghost commented Feb 15, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ElastiCache cluster does not document ARN output field
2 participants