Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/glue_ml_transform - new resource #14909

Merged
merged 23 commits into from
Sep 29, 2020
Merged

r/glue_ml_transform - new resource #14909

merged 23 commits into from
Sep 29, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Aug 29, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource_aws_glue_ml_transform - add new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueMLTransform_'
--- PASS: TestAccAWSGlueMLTransform_description (127.24s)
--- PASS: TestAccAWSGlueMLTransform_glueVersion (135.07s)
--- PASS: TestAccAWSGlueMLTransform_maxRetries (170.36s)
--- PASS: TestAccAWSGlueMLTransform_tags (166.78s)
--- PASS: TestAccAWSGlueMLTransform_timeout (135.02s)
--- PASS: TestAccAWSGlueMLTransform_maxCapacity (166.63s)
--- PASS: TestAccAWSGlueMLTransform_disappears (83.80s)
--- PASS: TestAccAWSGlueMLTransform_workerType (97.77s)
--- PASS: TestAccAWSGlueMLTransform_typeFindMatchesFull (128.74s)

@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Aug 29, 2020
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Aug 29, 2020
@DrFaust92 DrFaust92 marked this pull request as ready for review August 29, 2020 19:00
@DrFaust92 DrFaust92 requested a review from a team August 29, 2020 19:00
@ewbankkit
Copy link
Contributor

@DrFaust92 Now some failing new/updated linters 😢.

ewbankkit
ewbankkit approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueMLTransform_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueMLTransform_ -timeout 120m
=== RUN   TestAccAWSGlueMLTransform_basic
=== PAUSE TestAccAWSGlueMLTransform_basic
=== RUN   TestAccAWSGlueMLTransform_typeFindMatchesFull
=== PAUSE TestAccAWSGlueMLTransform_typeFindMatchesFull
=== RUN   TestAccAWSGlueMLTransform_description
=== PAUSE TestAccAWSGlueMLTransform_description
=== RUN   TestAccAWSGlueMLTransform_glueVersion
=== PAUSE TestAccAWSGlueMLTransform_glueVersion
=== RUN   TestAccAWSGlueMLTransform_maxRetries
=== PAUSE TestAccAWSGlueMLTransform_maxRetries
=== RUN   TestAccAWSGlueMLTransform_tags
=== PAUSE TestAccAWSGlueMLTransform_tags
=== RUN   TestAccAWSGlueMLTransform_timeout
=== PAUSE TestAccAWSGlueMLTransform_timeout
=== RUN   TestAccAWSGlueMLTransform_workerType
=== PAUSE TestAccAWSGlueMLTransform_workerType
=== RUN   TestAccAWSGlueMLTransform_maxCapacity
=== PAUSE TestAccAWSGlueMLTransform_maxCapacity
=== RUN   TestAccAWSGlueMLTransform_disappears
=== PAUSE TestAccAWSGlueMLTransform_disappears
=== CONT  TestAccAWSGlueMLTransform_basic
=== CONT  TestAccAWSGlueMLTransform_timeout
=== CONT  TestAccAWSGlueMLTransform_disappears
=== CONT  TestAccAWSGlueMLTransform_maxCapacity
=== CONT  TestAccAWSGlueMLTransform_workerType
=== CONT  TestAccAWSGlueMLTransform_glueVersion
=== CONT  TestAccAWSGlueMLTransform_tags
=== CONT  TestAccAWSGlueMLTransform_maxRetries
=== CONT  TestAccAWSGlueMLTransform_description
=== CONT  TestAccAWSGlueMLTransform_typeFindMatchesFull
=== CONT  TestAccAWSGlueMLTransform_disappears
    resource_aws_glue_ml_transform_test.go:436: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSGlueMLTransform_disappears (43.63s)
2020/09/24 10:29:06 [DEBUG] Waiting for state to become: []
--- PASS: TestAccAWSGlueMLTransform_basic (50.70s)
--- PASS: TestAccAWSGlueMLTransform_timeout (77.92s)
--- PASS: TestAccAWSGlueMLTransform_description (80.14s)
--- PASS: TestAccAWSGlueMLTransform_maxRetries (87.89s)
--- PASS: TestAccAWSGlueMLTransform_glueVersion (93.40s)
--- PASS: TestAccAWSGlueMLTransform_workerType (93.50s)
--- PASS: TestAccAWSGlueMLTransform_maxCapacity (93.59s)
--- PASS: TestAccAWSGlueMLTransform_tags (106.50s)
--- PASS: TestAccAWSGlueMLTransform_typeFindMatchesFull (113.44s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	113.495s

@breathingdust
Copy link
Member

LGTM! 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TESTARGS='-run=TestAccAWSGlueMLTransform_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueMLTransform_ -timeout 120m
=== RUN   TestAccAWSGlueMLTransform_basic
=== PAUSE TestAccAWSGlueMLTransform_basic
=== RUN   TestAccAWSGlueMLTransform_typeFindMatchesFull
=== PAUSE TestAccAWSGlueMLTransform_typeFindMatchesFull
=== RUN   TestAccAWSGlueMLTransform_description
=== PAUSE TestAccAWSGlueMLTransform_description
=== RUN   TestAccAWSGlueMLTransform_glueVersion
=== PAUSE TestAccAWSGlueMLTransform_glueVersion
=== RUN   TestAccAWSGlueMLTransform_maxRetries
=== PAUSE TestAccAWSGlueMLTransform_maxRetries
=== RUN   TestAccAWSGlueMLTransform_tags
=== PAUSE TestAccAWSGlueMLTransform_tags
=== RUN   TestAccAWSGlueMLTransform_timeout
=== PAUSE TestAccAWSGlueMLTransform_timeout
=== RUN   TestAccAWSGlueMLTransform_workerType
=== PAUSE TestAccAWSGlueMLTransform_workerType
=== RUN   TestAccAWSGlueMLTransform_maxCapacity
=== PAUSE TestAccAWSGlueMLTransform_maxCapacity
=== RUN   TestAccAWSGlueMLTransform_disappears
=== PAUSE TestAccAWSGlueMLTransform_disappears
=== CONT  TestAccAWSGlueMLTransform_basic
=== CONT  TestAccAWSGlueMLTransform_timeout
=== CONT  TestAccAWSGlueMLTransform_disappears
=== CONT  TestAccAWSGlueMLTransform_maxCapacity
=== CONT  TestAccAWSGlueMLTransform_workerType
=== CONT  TestAccAWSGlueMLTransform_glueVersion
=== CONT  TestAccAWSGlueMLTransform_tags
=== CONT  TestAccAWSGlueMLTransform_maxRetries
=== CONT  TestAccAWSGlueMLTransform_typeFindMatchesFull
=== CONT  TestAccAWSGlueMLTransform_description
=== CONT  TestAccAWSGlueMLTransform_disappears
    resource_aws_glue_ml_transform_test.go:436: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSGlueMLTransform_disappears (41.57s)
--- PASS: TestAccAWSGlueMLTransform_glueVersion (51.26s)
--- PASS: TestAccAWSGlueMLTransform_description (61.28s)
--- PASS: TestAccAWSGlueMLTransform_basic (63.05s)
--- PASS: TestAccAWSGlueMLTransform_workerType (71.34s)
--- PASS: TestAccAWSGlueMLTransform_maxCapacity (75.55s)
--- PASS: TestAccAWSGlueMLTransform_timeout (75.60s)
--- PASS: TestAccAWSGlueMLTransform_maxRetries (78.39s)
--- PASS: TestAccAWSGlueMLTransform_tags (89.42s)
--- PASS: TestAccAWSGlueMLTransform_typeFindMatchesFull (135.04s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	136.423s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TESTARGS='-run=TestAccAWSGlueMLTransform_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueMLTransform_ -timeout 120m
=== RUN   TestAccAWSGlueMLTransform_basic
=== PAUSE TestAccAWSGlueMLTransform_basic
=== RUN   TestAccAWSGlueMLTransform_typeFindMatchesFull
=== PAUSE TestAccAWSGlueMLTransform_typeFindMatchesFull
=== RUN   TestAccAWSGlueMLTransform_description
=== PAUSE TestAccAWSGlueMLTransform_description
=== RUN   TestAccAWSGlueMLTransform_glueVersion
=== PAUSE TestAccAWSGlueMLTransform_glueVersion
=== RUN   TestAccAWSGlueMLTransform_maxRetries
=== PAUSE TestAccAWSGlueMLTransform_maxRetries
=== RUN   TestAccAWSGlueMLTransform_tags
=== PAUSE TestAccAWSGlueMLTransform_tags
=== RUN   TestAccAWSGlueMLTransform_timeout
=== PAUSE TestAccAWSGlueMLTransform_timeout
=== RUN   TestAccAWSGlueMLTransform_workerType
=== PAUSE TestAccAWSGlueMLTransform_workerType
=== RUN   TestAccAWSGlueMLTransform_maxCapacity
=== PAUSE TestAccAWSGlueMLTransform_maxCapacity
=== RUN   TestAccAWSGlueMLTransform_disappears
=== PAUSE TestAccAWSGlueMLTransform_disappears
=== CONT  TestAccAWSGlueMLTransform_basic
=== CONT  TestAccAWSGlueMLTransform_timeout
=== CONT  TestAccAWSGlueMLTransform_description
=== CONT  TestAccAWSGlueMLTransform_glueVersion
=== CONT  TestAccAWSGlueMLTransform_tags
=== CONT  TestAccAWSGlueMLTransform_maxRetries
=== CONT  TestAccAWSGlueMLTransform_disappears
=== CONT  TestAccAWSGlueMLTransform_maxCapacity
=== CONT  TestAccAWSGlueMLTransform_workerType
=== CONT  TestAccAWSGlueMLTransform_typeFindMatchesFull
2020/09/29 14:55:31 [DEBUG] Trying to get account information via sts:GetCallerIdentity
=== CONT  TestAccAWSGlueMLTransform_disappears
    resource_aws_glue_ml_transform_test.go:436: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSGlueMLTransform_disappears (22.09s)
--- PASS: TestAccAWSGlueMLTransform_basic (33.17s)
--- PASS: TestAccAWSGlueMLTransform_maxRetries (42.33s)
--- PASS: TestAccAWSGlueMLTransform_description (52.32s)
--- PASS: TestAccAWSGlueMLTransform_workerType (56.03s)
--- PASS: TestAccAWSGlueMLTransform_glueVersion (59.38s)
--- PASS: TestAccAWSGlueMLTransform_typeFindMatchesFull (67.03s)
--- PASS: TestAccAWSGlueMLTransform_timeout (80.34s)
--- PASS: TestAccAWSGlueMLTransform_tags (83.12s)
--- PASS: TestAccAWSGlueMLTransform_maxCapacity (138.63s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	140.014s

@breathingdust breathingdust added this to the v3.9.0 milestone Sep 29, 2020
@breathingdust breathingdust linked an issue Sep 29, 2020 that may be closed by this pull request
Feature Request: Resource for managing AWS Glue ML Transforms #13424
Closed
@breathingdust breathingdust merged commit 72036b8 into hashicorp:master Sep 29, 2020
breathingdust added a commit that referenced this pull request Sep 29, 2020
@breathingdust
Update CHANGELOG for #14909
3a39299
@ghost
Copy link

ghost commented Oct 2, 2020

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 30, 2020
@DrFaust92 DrFaust92 deleted the r/glue_ml_transform branch April 15, 2021 10:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/glue Issues and PRs that pertain to the glue service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

Feature Request: Resource for managing AWS Glue ML Transforms
3 participants
@DrFaust92 @ewbankkit @breathingdust