aws_ec2_transit_gateway_route: cidr match is unreliable

[thekev]

• aws api returns expanded prefix, but hcl may contain compressed prefix
• use cidrBlocksEqual() instead of string comparison to find route
• normalize route destination value to RFC1924 compressed

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #14845

Release note for CHANGELOG:

Improve reliability of route matching for transit gateway routes.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEc2TransitGatewayRoute_basic_ipv6' ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 3 -run=TestAccAWSEc2TransitGatewayRoute_basic_ipv6 -timeout 120m
=== RUN   TestAccAWSEc2TransitGatewayRoute_basic_ipv6
=== PAUSE TestAccAWSEc2TransitGatewayRoute_basic_ipv6
=== CONT  TestAccAWSEc2TransitGatewayRoute_basic_ipv6
--- PASS: TestAccAWSEc2TransitGatewayRoute_basic_ipv6 (327.71s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	329.745s
$ make testacc TESTARGS='-run=Test_canonicalCidrBlock' ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 3 -run=Test_canonicalCidrBlock -timeout 120m
=== RUN   Test_canonicalCidrBlock
--- PASS: Test_canonicalCidrBlock (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1.823s

[ewbankkit]

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEc2TransitGatewayRoute_basic_ipv6'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEc2TransitGatewayRoute_basic_ipv6 -timeout 120m
=== RUN   TestAccAWSEc2TransitGatewayRoute_basic_ipv6
=== PAUSE TestAccAWSEc2TransitGatewayRoute_basic_ipv6
=== CONT  TestAccAWSEc2TransitGatewayRoute_basic_ipv6
--- PASS: TestAccAWSEc2TransitGatewayRoute_basic_ipv6 (306.79s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	306.826s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEc2TransitGatewayRoute_basic$$'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEc2TransitGatewayRoute_basic$ -timeout 120m
=== RUN   TestAccAWSEc2TransitGatewayRoute_basic
=== PAUSE TestAccAWSEc2TransitGatewayRoute_basic
=== CONT  TestAccAWSEc2TransitGatewayRoute_basic
--- PASS: TestAccAWSEc2TransitGatewayRoute_basic (304.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	304.134s

[ewbankkit]

Looks good apart from minor suggested change.

[ewbankkit]

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEc2TransitGatewayRoute_basic_ipv6'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEc2TransitGatewayRoute_basic_ipv6 -timeout 120m
=== RUN   TestAccAWSEc2TransitGatewayRoute_basic_ipv6
=== PAUSE TestAccAWSEc2TransitGatewayRoute_basic_ipv6
=== CONT  TestAccAWSEc2TransitGatewayRoute_basic_ipv6
--- PASS: TestAccAWSEc2TransitGatewayRoute_basic_ipv6 (393.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	393.464s

[DrFaust92]

LGTM

--- PASS: TestAccAWSEc2TransitGatewayRoute_basic_ipv6 (382.25s)

[gdavison]

LGTM 🚀

--- PASS: TestCanonicalCidrBlock (0.00s)
--- PASS: TestAccAWSEc2TransitGatewayRouteTable_disappears_TransitGateway (254.06s)
--- PASS: TestAccAWSEc2TransitGatewayRouteTable_disappears (308.93s)
--- PASS: TestAccAWSEc2TransitGatewayRoute_disappears (369.18s)
--- PASS: TestAccAWSEc2TransitGatewayRoute_disappears_TransitGatewayAttachment (371.33s)
--- PASS: TestAccAWSEc2TransitGatewayRouteTable_basic (372.06s)
--- PASS: TestAccAWSEc2TransitGatewayRouteTableDataSource_ID (371.42s)
--- PASS: TestAccAWSEc2TransitGatewayRouteTablePropagation_basic (372.35s)
--- PASS: TestAccAWSEc2TransitGatewayRouteTableDataSource_Filter (372.46s)
--- PASS: TestAccAWSEc2TransitGatewayRouteTable_Tags (372.87s)
--- PASS: TestAccAWSEc2TransitGatewayRoute_basic (431.73s)
--- PASS: TestAccAWSEc2TransitGatewayRoute_blackhole (431.61s)
--- PASS: TestAccAWSEc2TransitGatewayRoute_basic_ipv6 (433.33s)
--- PASS: TestAccAWSEc2TransitGatewayRouteTableAssociation_basic (492.15s)

[ghost]

This has been released in version 3.11.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!