Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/glue_crawler - add support for scan_all and scan_rate arguments for ddb targets #14819

Merged
merged 4 commits into from
Sep 23, 2020
Merged

r/glue_crawler - add support for scan_all and scan_rate arguments for ddb targets #14819

merged 4 commits into from
Sep 23, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource_aws_glue_crawler - add support for `scan_all` and `scan_rate` arguments for ddb targets

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueCrawler_DynamodbTarget'
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget_scanAll (252.19s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget_scanRate (302.13s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget (130.64s)

@DrFaust92 DrFaust92 requested a review from a team August 25, 2020 10:01
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Aug 25, 2020
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 25, 2020
ewbankkit
ewbankkit reviewed Sep 23, 2020
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueCrawler_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueCrawler_ -timeout 120m
=== RUN   TestAccAWSGlueCrawler_DynamodbTarget
=== PAUSE TestAccAWSGlueCrawler_DynamodbTarget
=== RUN   TestAccAWSGlueCrawler_DynamodbTarget_scanAll
=== PAUSE TestAccAWSGlueCrawler_DynamodbTarget_scanAll
=== RUN   TestAccAWSGlueCrawler_DynamodbTarget_scanRate
=== PAUSE TestAccAWSGlueCrawler_DynamodbTarget_scanRate
=== RUN   TestAccAWSGlueCrawler_JdbcTarget
=== PAUSE TestAccAWSGlueCrawler_JdbcTarget
=== RUN   TestAccAWSGlueCrawler_JdbcTarget_Exclusions
=== PAUSE TestAccAWSGlueCrawler_JdbcTarget_Exclusions
=== RUN   TestAccAWSGlueCrawler_JdbcTarget_Multiple
=== PAUSE TestAccAWSGlueCrawler_JdbcTarget_Multiple
=== RUN   TestAccAWSGlueCrawler_S3Target
=== PAUSE TestAccAWSGlueCrawler_S3Target
=== RUN   TestAccAWSGlueCrawler_S3Target_Exclusions
=== PAUSE TestAccAWSGlueCrawler_S3Target_Exclusions
=== RUN   TestAccAWSGlueCrawler_S3Target_Multiple
=== PAUSE TestAccAWSGlueCrawler_S3Target_Multiple
=== RUN   TestAccAWSGlueCrawler_CatalogTarget
=== PAUSE TestAccAWSGlueCrawler_CatalogTarget
=== RUN   TestAccAWSGlueCrawler_CatalogTarget_Multiple
=== PAUSE TestAccAWSGlueCrawler_CatalogTarget_Multiple
=== RUN   TestAccAWSGlueCrawler_disappears
=== PAUSE TestAccAWSGlueCrawler_disappears
=== RUN   TestAccAWSGlueCrawler_Classifiers
=== PAUSE TestAccAWSGlueCrawler_Classifiers
=== RUN   TestAccAWSGlueCrawler_Configuration
=== PAUSE TestAccAWSGlueCrawler_Configuration
=== RUN   TestAccAWSGlueCrawler_Description
=== PAUSE TestAccAWSGlueCrawler_Description
=== RUN   TestAccAWSGlueCrawler_Role_ARN_NoPath
=== PAUSE TestAccAWSGlueCrawler_Role_ARN_NoPath
=== RUN   TestAccAWSGlueCrawler_Role_ARN_Path
=== PAUSE TestAccAWSGlueCrawler_Role_ARN_Path
=== RUN   TestAccAWSGlueCrawler_Role_Name_Path
=== PAUSE TestAccAWSGlueCrawler_Role_Name_Path
=== RUN   TestAccAWSGlueCrawler_Schedule
=== PAUSE TestAccAWSGlueCrawler_Schedule
=== RUN   TestAccAWSGlueCrawler_SchemaChangePolicy
=== PAUSE TestAccAWSGlueCrawler_SchemaChangePolicy
=== RUN   TestAccAWSGlueCrawler_TablePrefix
=== PAUSE TestAccAWSGlueCrawler_TablePrefix
=== RUN   TestAccAWSGlueCrawler_Tags
=== PAUSE TestAccAWSGlueCrawler_Tags
=== RUN   TestAccAWSGlueCrawler_SecurityConfiguration
=== PAUSE TestAccAWSGlueCrawler_SecurityConfiguration
=== CONT  TestAccAWSGlueCrawler_DynamodbTarget
=== CONT  TestAccAWSGlueCrawler_Classifiers
=== CONT  TestAccAWSGlueCrawler_SecurityConfiguration
=== CONT  TestAccAWSGlueCrawler_Tags
=== CONT  TestAccAWSGlueCrawler_TablePrefix
=== CONT  TestAccAWSGlueCrawler_SchemaChangePolicy
=== CONT  TestAccAWSGlueCrawler_Schedule
=== CONT  TestAccAWSGlueCrawler_Role_Name_Path
=== CONT  TestAccAWSGlueCrawler_Role_ARN_Path
=== CONT  TestAccAWSGlueCrawler_Role_ARN_NoPath
=== CONT  TestAccAWSGlueCrawler_Description
=== CONT  TestAccAWSGlueCrawler_disappears
=== CONT  TestAccAWSGlueCrawler_CatalogTarget_Multiple
=== CONT  TestAccAWSGlueCrawler_CatalogTarget
=== CONT  TestAccAWSGlueCrawler_S3Target_Multiple
=== CONT  TestAccAWSGlueCrawler_S3Target_Exclusions
=== CONT  TestAccAWSGlueCrawler_S3Target
=== CONT  TestAccAWSGlueCrawler_JdbcTarget_Multiple
=== CONT  TestAccAWSGlueCrawler_JdbcTarget_Exclusions
=== CONT  TestAccAWSGlueCrawler_JdbcTarget
=== CONT  TestAccAWSGlueCrawler_CatalogTarget_Multiple
    resource_aws_glue_crawler_test.go:619: Step 1/4 error: terraform failed: exit status 1
        
        stderr:
        
        Error: error creating Glue crawler: InvalidInputException: Insufficient Lake Formation permission(s) on tf-acc-test-3949665362889455165_table_0 (Service: AmazonDataCatalog; Status Code: 400; Error Code: AccessDeniedException; Request ID: 8f170c96-6ff7-46c9-a2da-11362cc80432; Proxy: null)
        
        
=== CONT  TestAccAWSGlueCrawler_CatalogTarget
    resource_aws_glue_crawler_test.go:547: Step 1/3 error: terraform failed: exit status 1
        
        stderr:
        
        Error: error creating Glue crawler: InvalidInputException: Insufficient Lake Formation permission(s) on tf-acc-test-5116668372247841626_table_0 (Service: AmazonDataCatalog; Status Code: 400; Error Code: AccessDeniedException; Request ID: 318dc131-50aa-4bf5-8286-54a37c35d192; Proxy: null)
        
        
--- FAIL: TestAccAWSGlueCrawler_CatalogTarget (55.85s)
=== CONT  TestAccAWSGlueCrawler_DynamodbTarget_scanRate
--- FAIL: TestAccAWSGlueCrawler_CatalogTarget_Multiple (55.85s)
=== CONT  TestAccAWSGlueCrawler_DynamodbTarget_scanAll
=== CONT  TestAccAWSGlueCrawler_disappears
    resource_aws_glue_crawler_test.go:674: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSGlueCrawler_disappears (85.24s)
=== CONT  TestAccAWSGlueCrawler_Configuration
--- PASS: TestAccAWSGlueCrawler_Role_Name_Path (97.04s)
--- PASS: TestAccAWSGlueCrawler_Role_ARN_Path (119.05s)
--- PASS: TestAccAWSGlueCrawler_Role_ARN_NoPath (119.39s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget (169.47s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Exclusions (170.63s)
--- PASS: TestAccAWSGlueCrawler_S3Target (179.76s)
--- PASS: TestAccAWSGlueCrawler_SchemaChangePolicy (180.28s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Exclusions (180.59s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget (181.27s)
--- PASS: TestAccAWSGlueCrawler_Description (181.38s)
--- PASS: TestAccAWSGlueCrawler_TablePrefix (181.41s)
--- PASS: TestAccAWSGlueCrawler_SecurityConfiguration (181.85s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Multiple (212.45s)
--- PASS: TestAccAWSGlueCrawler_Schedule (212.56s)
--- PASS: TestAccAWSGlueCrawler_Classifiers (212.60s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Multiple (212.81s)
--- PASS: TestAccAWSGlueCrawler_Tags (213.17s)
--- PASS: TestAccAWSGlueCrawler_Configuration (130.16s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget_scanRate (165.45s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget_scanAll (165.45s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	221.364s
FAIL
GNUmakefile:27: recipe for target 'testacc' failed
make: *** [testacc] Error 1

The failures are unrelated to this change and seem to be caused by having Lake Formation enabled for the testing account.

@breathingdust
Copy link
Member

LGTM! 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueCrawler_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueCrawler_ -timeout 120m
=== RUN   TestAccAWSGlueCrawler_DynamodbTarget
=== PAUSE TestAccAWSGlueCrawler_DynamodbTarget
=== RUN   TestAccAWSGlueCrawler_DynamodbTarget_scanAll
=== PAUSE TestAccAWSGlueCrawler_DynamodbTarget_scanAll
=== RUN   TestAccAWSGlueCrawler_DynamodbTarget_scanRate
=== PAUSE TestAccAWSGlueCrawler_DynamodbTarget_scanRate
=== RUN   TestAccAWSGlueCrawler_JdbcTarget
=== PAUSE TestAccAWSGlueCrawler_JdbcTarget
=== RUN   TestAccAWSGlueCrawler_JdbcTarget_Exclusions
=== PAUSE TestAccAWSGlueCrawler_JdbcTarget_Exclusions
=== RUN   TestAccAWSGlueCrawler_JdbcTarget_Multiple
=== PAUSE TestAccAWSGlueCrawler_JdbcTarget_Multiple
=== RUN   TestAccAWSGlueCrawler_S3Target
=== PAUSE TestAccAWSGlueCrawler_S3Target
=== RUN   TestAccAWSGlueCrawler_S3Target_Exclusions
=== PAUSE TestAccAWSGlueCrawler_S3Target_Exclusions
=== RUN   TestAccAWSGlueCrawler_S3Target_Multiple
=== PAUSE TestAccAWSGlueCrawler_S3Target_Multiple
=== RUN   TestAccAWSGlueCrawler_CatalogTarget
=== PAUSE TestAccAWSGlueCrawler_CatalogTarget
=== RUN   TestAccAWSGlueCrawler_CatalogTarget_Multiple
=== PAUSE TestAccAWSGlueCrawler_CatalogTarget_Multiple
=== RUN   TestAccAWSGlueCrawler_disappears
=== PAUSE TestAccAWSGlueCrawler_disappears
=== RUN   TestAccAWSGlueCrawler_Classifiers
=== PAUSE TestAccAWSGlueCrawler_Classifiers
=== RUN   TestAccAWSGlueCrawler_Configuration
=== PAUSE TestAccAWSGlueCrawler_Configuration
=== RUN   TestAccAWSGlueCrawler_Description
=== PAUSE TestAccAWSGlueCrawler_Description
=== RUN   TestAccAWSGlueCrawler_Role_ARN_NoPath
=== PAUSE TestAccAWSGlueCrawler_Role_ARN_NoPath
=== RUN   TestAccAWSGlueCrawler_Role_ARN_Path
=== PAUSE TestAccAWSGlueCrawler_Role_ARN_Path
=== RUN   TestAccAWSGlueCrawler_Role_Name_Path
=== PAUSE TestAccAWSGlueCrawler_Role_Name_Path
=== RUN   TestAccAWSGlueCrawler_Schedule
=== PAUSE TestAccAWSGlueCrawler_Schedule
=== RUN   TestAccAWSGlueCrawler_SchemaChangePolicy
=== PAUSE TestAccAWSGlueCrawler_SchemaChangePolicy
=== RUN   TestAccAWSGlueCrawler_TablePrefix
=== PAUSE TestAccAWSGlueCrawler_TablePrefix
=== RUN   TestAccAWSGlueCrawler_Tags
=== PAUSE TestAccAWSGlueCrawler_Tags
=== RUN   TestAccAWSGlueCrawler_SecurityConfiguration
=== PAUSE TestAccAWSGlueCrawler_SecurityConfiguration
=== CONT  TestAccAWSGlueCrawler_DynamodbTarget
=== CONT  TestAccAWSGlueCrawler_Classifiers
=== CONT  TestAccAWSGlueCrawler_DynamodbTarget_scanRate
=== CONT  TestAccAWSGlueCrawler_S3Target
=== CONT  TestAccAWSGlueCrawler_disappears
=== CONT  TestAccAWSGlueCrawler_CatalogTarget_Multiple
=== CONT  TestAccAWSGlueCrawler_CatalogTarget
=== CONT  TestAccAWSGlueCrawler_S3Target_Multiple
=== CONT  TestAccAWSGlueCrawler_JdbcTarget
=== CONT  TestAccAWSGlueCrawler_JdbcTarget_Multiple
=== CONT  TestAccAWSGlueCrawler_S3Target_Exclusions
=== CONT  TestAccAWSGlueCrawler_Schedule
=== CONT  TestAccAWSGlueCrawler_SecurityConfiguration
=== CONT  TestAccAWSGlueCrawler_Tags
=== CONT  TestAccAWSGlueCrawler_TablePrefix
=== CONT  TestAccAWSGlueCrawler_JdbcTarget_Exclusions
=== CONT  TestAccAWSGlueCrawler_Role_ARN_NoPath
=== CONT  TestAccAWSGlueCrawler_Role_Name_Path
=== CONT  TestAccAWSGlueCrawler_SchemaChangePolicy
=== CONT  TestAccAWSGlueCrawler_Role_ARN_Path
2020/09/23 14:38:45 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/09/23 14:38:47 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
2020/09/23 14:38:47 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/09/23 14:38:49 [DEBUG] Getting IAM Policy: {
  PolicyArn: "arn:aws:iam::aws:policy/service-role/AWSGlueServiceRole"
}
2020/09/23 14:38:49 [DEBUG] Waiting for state to become: [success]
2020/09/23 14:38:53 [DEBUG] Waiting for state to become: [success]
--- PASS: TestAccAWSGlueCrawler_Role_ARN_Path (33.34s)
=== CONT  TestAccAWSGlueCrawler_DynamodbTarget_scanAll
=== CONT  TestAccAWSGlueCrawler_disappears
    resource_aws_glue_crawler_test.go:674: [INFO] Got non-empty plan, as expected
=== CONT  TestAccAWSGlueCrawler_Configuration
--- PASS: TestAccAWSGlueCrawler_disappears (37.76s)
--- PASS: TestAccAWSGlueCrawler_Role_Name_Path (42.08s)
=== CONT  TestAccAWSGlueCrawler_Description
--- PASS: TestAccAWSGlueCrawler_Role_ARN_NoPath (42.30s)
2020/09/23 14:39:13 [DEBUG] Waiting for state to become: [success]
--- PASS: TestAccAWSGlueCrawler_S3Target_Exclusions (60.58s)
--- PASS: TestAccAWSGlueCrawler_TablePrefix (60.89s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Exclusions (62.41s)
--- PASS: TestAccAWSGlueCrawler_S3Target (63.06s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget (63.16s)
2020/09/23 14:39:25 [DEBUG] Trying to get account information via sts:GetCallerIdentity
--- PASS: TestAccAWSGlueCrawler_JdbcTarget (66.10s)
--- PASS: TestAccAWSGlueCrawler_SecurityConfiguration (71.47s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget_scanRate (76.61s)
--- PASS: TestAccAWSGlueCrawler_CatalogTarget (76.74s)
--- PASS: TestAccAWSGlueCrawler_Tags (78.33s)
--- PASS: TestAccAWSGlueCrawler_Schedule (80.04s)
--- PASS: TestAccAWSGlueCrawler_SchemaChangePolicy (80.94s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Multiple (85.81s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Multiple (85.88s)
--- PASS: TestAccAWSGlueCrawler_Classifiers (86.12s)
--- PASS: TestAccAWSGlueCrawler_Configuration (50.00s)
--- PASS: TestAccAWSGlueCrawler_Description (46.23s)
--- PASS: TestAccAWSGlueCrawler_CatalogTarget_Multiple (88.67s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget_scanAll (65.15s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	99.795s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueCrawler_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueCrawler_ -timeout 120m
=== RUN   TestAccAWSGlueCrawler_DynamodbTarget
=== PAUSE TestAccAWSGlueCrawler_DynamodbTarget
=== RUN   TestAccAWSGlueCrawler_DynamodbTarget_scanAll
=== PAUSE TestAccAWSGlueCrawler_DynamodbTarget_scanAll
=== RUN   TestAccAWSGlueCrawler_DynamodbTarget_scanRate
=== PAUSE TestAccAWSGlueCrawler_DynamodbTarget_scanRate
=== RUN   TestAccAWSGlueCrawler_JdbcTarget
=== PAUSE TestAccAWSGlueCrawler_JdbcTarget
=== RUN   TestAccAWSGlueCrawler_JdbcTarget_Exclusions
=== PAUSE TestAccAWSGlueCrawler_JdbcTarget_Exclusions
=== RUN   TestAccAWSGlueCrawler_JdbcTarget_Multiple
=== PAUSE TestAccAWSGlueCrawler_JdbcTarget_Multiple
=== RUN   TestAccAWSGlueCrawler_S3Target
=== PAUSE TestAccAWSGlueCrawler_S3Target
=== RUN   TestAccAWSGlueCrawler_S3Target_Exclusions
=== PAUSE TestAccAWSGlueCrawler_S3Target_Exclusions
=== RUN   TestAccAWSGlueCrawler_S3Target_Multiple
=== PAUSE TestAccAWSGlueCrawler_S3Target_Multiple
=== RUN   TestAccAWSGlueCrawler_CatalogTarget
=== PAUSE TestAccAWSGlueCrawler_CatalogTarget
=== RUN   TestAccAWSGlueCrawler_CatalogTarget_Multiple
=== PAUSE TestAccAWSGlueCrawler_CatalogTarget_Multiple
=== RUN   TestAccAWSGlueCrawler_disappears
=== PAUSE TestAccAWSGlueCrawler_disappears
=== RUN   TestAccAWSGlueCrawler_Classifiers
=== PAUSE TestAccAWSGlueCrawler_Classifiers
=== RUN   TestAccAWSGlueCrawler_Configuration
=== PAUSE TestAccAWSGlueCrawler_Configuration
=== RUN   TestAccAWSGlueCrawler_Description
=== PAUSE TestAccAWSGlueCrawler_Description
=== RUN   TestAccAWSGlueCrawler_Role_ARN_NoPath
=== PAUSE TestAccAWSGlueCrawler_Role_ARN_NoPath
=== RUN   TestAccAWSGlueCrawler_Role_ARN_Path
=== PAUSE TestAccAWSGlueCrawler_Role_ARN_Path
=== RUN   TestAccAWSGlueCrawler_Role_Name_Path
=== PAUSE TestAccAWSGlueCrawler_Role_Name_Path
=== RUN   TestAccAWSGlueCrawler_Schedule
=== PAUSE TestAccAWSGlueCrawler_Schedule
=== RUN   TestAccAWSGlueCrawler_SchemaChangePolicy
=== PAUSE TestAccAWSGlueCrawler_SchemaChangePolicy
=== RUN   TestAccAWSGlueCrawler_TablePrefix
=== PAUSE TestAccAWSGlueCrawler_TablePrefix
=== RUN   TestAccAWSGlueCrawler_Tags
=== PAUSE TestAccAWSGlueCrawler_Tags
=== RUN   TestAccAWSGlueCrawler_SecurityConfiguration
=== PAUSE TestAccAWSGlueCrawler_SecurityConfiguration
=== CONT  TestAccAWSGlueCrawler_DynamodbTarget
=== CONT  TestAccAWSGlueCrawler_Classifiers
=== CONT  TestAccAWSGlueCrawler_S3Target
=== CONT  TestAccAWSGlueCrawler_SecurityConfiguration
=== CONT  TestAccAWSGlueCrawler_Tags
=== CONT  TestAccAWSGlueCrawler_TablePrefix
=== CONT  TestAccAWSGlueCrawler_SchemaChangePolicy
=== CONT  TestAccAWSGlueCrawler_Schedule
=== CONT  TestAccAWSGlueCrawler_Role_Name_Path
=== CONT  TestAccAWSGlueCrawler_Role_ARN_Path
=== CONT  TestAccAWSGlueCrawler_Role_ARN_NoPath
=== CONT  TestAccAWSGlueCrawler_Description
=== CONT  TestAccAWSGlueCrawler_Configuration
=== CONT  TestAccAWSGlueCrawler_JdbcTarget
=== CONT  TestAccAWSGlueCrawler_JdbcTarget_Multiple
=== CONT  TestAccAWSGlueCrawler_CatalogTarget
=== CONT  TestAccAWSGlueCrawler_disappears
=== CONT  TestAccAWSGlueCrawler_JdbcTarget_Exclusions
=== CONT  TestAccAWSGlueCrawler_CatalogTarget_Multiple
=== CONT  TestAccAWSGlueCrawler_DynamodbTarget_scanAll
2020/09/23 14:41:54 [DEBUG] Trying to get account information via sts:GetCallerIdentity
=== CONT  TestAccAWSGlueCrawler_disappears
    resource_aws_glue_crawler_test.go:674: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSGlueCrawler_Role_Name_Path (35.81s)
=== CONT  TestAccAWSGlueCrawler_DynamodbTarget_scanRate
--- PASS: TestAccAWSGlueCrawler_disappears (35.95s)
=== CONT  TestAccAWSGlueCrawler_S3Target_Multiple
2020/09/23 14:42:00 [DEBUG] Getting IAM Policy Version: {
  PolicyArn: "arn:aws-us-gov:iam::aws:policy/service-role/AWSGlueServiceRole",
  VersionId: "v2"
}
2020/09/23 14:42:00 [DEBUG] Waiting for state to become: [success]
--- PASS: TestAccAWSGlueCrawler_Role_ARN_Path (38.37s)
=== CONT  TestAccAWSGlueCrawler_S3Target_Exclusions
--- PASS: TestAccAWSGlueCrawler_Role_ARN_NoPath (39.64s)
2020/09/23 14:42:03 [DEBUG] Trying to get account information via sts:GetCallerIdentity
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget (42.04s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Exclusions (45.25s)
--- PASS: TestAccAWSGlueCrawler_TablePrefix (45.71s)
--- PASS: TestAccAWSGlueCrawler_Configuration (49.15s)
2020/09/23 14:42:17 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
--- PASS: TestAccAWSGlueCrawler_Tags (57.47s)
--- PASS: TestAccAWSGlueCrawler_Schedule (58.94s)
--- PASS: TestAccAWSGlueCrawler_CatalogTarget (59.43s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Multiple (61.07s)
2020/09/23 14:42:23 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/09/23 14:42:23 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/09/23 14:42:23 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/09/23 14:42:24 [DEBUG] Trying to get account information via sts:GetCallerIdentity
--- PASS: TestAccAWSGlueCrawler_Description (64.69s)
--- PASS: TestAccAWSGlueCrawler_SecurityConfiguration (66.49s)
--- PASS: TestAccAWSGlueCrawler_Classifiers (68.61s)
--- PASS: TestAccAWSGlueCrawler_S3Target (69.71s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget (74.17s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Exclusions (36.09s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget_scanRate (44.53s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Multiple (46.64s)
--- PASS: TestAccAWSGlueCrawler_CatalogTarget_Multiple (84.96s)
--- PASS: TestAccAWSGlueCrawler_SchemaChangePolicy (92.87s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget_scanAll (94.49s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	95.882s

@breathingdust breathingdust added this to the v3.8.0 milestone Sep 23, 2020
@breathingdust breathingdust merged commit b9583ca into hashicorp:master Sep 23, 2020
breathingdust added a commit that referenced this pull request Sep 23, 2020
@breathingdust
Update CHANGELOG.md for #14819
d643426
@DrFaust92 DrFaust92 deleted the r/glue_crawler_ddb_targets branch September 23, 2020 21:51
@ghost
Copy link

ghost commented Sep 24, 2020

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DrFaust92 @breathingdust @ewbankkit