Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The aws_ecr_repository data source doesn't work across accounts #14327

Closed
tedivm opened this issue Jul 23, 2020 · 4 comments · Fixed by #14368
Closed

The aws_ecr_repository data source doesn't work across accounts #14327

tedivm opened this issue Jul 23, 2020 · 4 comments · Fixed by #14368
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecr Issues and PRs that pertain to the ecr service.
Milestone

Comments

@tedivm
Copy link

tedivm commented Jul 23, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The aws_ecr_repository data source doesn't work for cross account repositories, as it has no way to specify the account ID. The aws_ecr_image object does allow this, but doesn't have a way to get the repository out of it.

New or Affected Resource(s)

  • aws_ecr_repository

Potential Terraform Configuration

data "aws_ecr_repository" "service" {
  name = "ecr-repository"
  registry_id = "394802378"
}

References

@tedivm tedivm added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 23, 2020
@ghost ghost added the service/ecr Issues and PRs that pertain to the ecr service. label Jul 23, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 23, 2020
@DrFaust92 DrFaust92 removed the needs-triage Waiting for first response or review from a maintainer. label Jul 28, 2020
@DrFaust92
Copy link
Collaborator

opened #14368 to address this

@bflad bflad added this to the v3.1.0 milestone Jul 31, 2020
@bflad
Copy link
Contributor

bflad commented Jul 31, 2020

Support for this argument has been merged and will release with version 3.1.0 of the Terraform AWS Provider, Thursday next week. Thanks to @DrFaust92 for the implementation. 👍

@ghost
Copy link

ghost commented Aug 7, 2020

This has been released in version 3.1.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecr Issues and PRs that pertain to the ecr service.
Projects
None yet
3 participants