Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle NotImplemented error code for AWS Snowball for object lock #13366

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

harshavardhana
Copy link

@harshavardhana harshavardhana commented May 16, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #23278

Release note for CHANGELOG:


Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@harshavardhana harshavardhana requested a review from a team May 16, 2020 18:15
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/s3 Issues and PRs that pertain to the s3 service. labels May 16, 2020
@zzzuzik
Copy link

zzzuzik commented Jun 10, 2020

any updates for this PR? The provider's S3 functionality cannot be used against Minio as of today. Thank you

@harshavardhana
Copy link
Author

any updates for this PR? The provider's S3 functionality cannot be used against Minio as of today. Thank you

It also true when run against AWS Snowball.

@harshavardhana
Copy link
Author

Can anyone look at this PR?

Base automatically changed from master to main January 23, 2021 00:57
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:57
@harshavardhana
Copy link
Author

Can anyone look at this PR?

Bump 👍🏽

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 27, 2021
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this patch @harshavardhana , LGTM 🚀

Output of acceptance tests:

--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (19.99s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (20.16s)
--- PASS: TestAccS3Bucket_Manage_objectLock (21.45s)
--- PASS: TestAccS3Bucket_Basic_basic (22.87s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (25.04s)
--- PASS: TestAccS3Bucket_Manage_objectLock_deprecatedEnabled (20.08s)
--- PASS: TestAccS3Bucket_Manage_objectLockWithVersioning (23.56s)
--- PASS: TestAccS3Bucket_Manage_objectLockWithVersioning_deprecatedEnabled (24.04s)
--- PASS: TestAccS3Bucket_Manage_objectLock_migrate (26.27s)
--- PASS: TestAccS3Bucket_Tags_basic (24.19s)
--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (13.67s)
--- PASS: TestAccS3Bucket_Basic_generatedName (19.90s)
--- PASS: TestAccS3Bucket_Basic_namePrefix (19.83s)
--- PASS: TestAccS3Bucket_Basic_emptyString (18.82s)
--- PASS: TestAccS3Bucket_Tags_ignoreTags (35.02s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (65.59s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (115.46s)

@anGie44 anGie44 added this to the v4.5.0 milestone Mar 11, 2022
@anGie44 anGie44 merged commit ccc60a8 into hashicorp:main Mar 11, 2022
@harshavardhana harshavardhana deleted the patch-1 branch March 11, 2022 03:09
@github-actions
Copy link

This functionality has been released in v4.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants