Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/cloudwatch_event_target - add validations + refactor tests #11685

Merged
merged 5 commits into from
Oct 30, 2020
Merged

r/cloudwatch_event_target - add validations + refactor tests #11685

merged 5 commits into from
Oct 30, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jan 21, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13624
Relates #13826

Release note for CHANGELOG:

resource_aws_cloudwatch_event_target: add plan time validation to `arn`, `role_arn`, `launch_type`, `task_definition_arn`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudWatchEventTarget_'
--- PASS: TestAccAWSCloudWatchEventTarget_basic (97.16s)
--- PASS: TestAccAWSCloudWatchEventTarget_missingTargetId (51.76s)
--- PASS: TestAccAWSCloudWatchEventTarget_full (106.93s)
--- PASS: TestAccAWSCloudWatchEventTarget_ssmDocument (60.37s)
--- PASS: TestAccAWSCloudWatchEventTarget_ecs (100.31s)
--- PASS: TestAccAWSCloudWatchEventTarget_ecsWithBlankTaskCount (93.94s)
--- PASS: TestAccAWSCloudWatchEventTarget_batch (137.84s)
--- PASS: TestAccAWSCloudWatchEventTarget_kinesis (106.64s)
--- PASS: TestAccAWSCloudWatchEventTarget_sqs (51.59s)
--- PASS: TestAccAWSCloudWatchEventTarget_input_transformer (75.23s)
--- PASS: TestAccAWSCloudWatchEventTarget_disappears (46.24s)

@DrFaust92 DrFaust92 requested a review from a team January 21, 2020 09:25
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. service/cloudwatchevents tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jan 21, 2020
@DrFaust92 DrFaust92 changed the title [WIP]r/cloudwatch_event_target - add validations + refactor tests r/cloudwatch_event_target - add validations + refactor tests Jan 21, 2020
slapula
slapula approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@slapula slapula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (aside from the random ECS teardown failures see #4852)

@DrFaust92 DrFaust92 force-pushed the event_target_refactor branch from 26fe207 to 63d918f Compare May 22, 2020 09:04
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels May 22, 2020
@DrFaust92
Copy link
Collaborator Author

rebased + added disappears test

@DrFaust92 DrFaust92 force-pushed the event_target_refactor branch from dd5f9dd to a938ff8 Compare July 2, 2020 18:29
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 4, 2020
@DrFaust92
refactor error
e97600a 
add plan time validation to `arn`, `role_arn`, `launch_type`, `task_definition_arn`
refactor tests
@DrFaust92
refactor tests
d64a8be
@DrFaust92
fix
34a519f
@DrFaust92
disappears test
fce5f99 
use aws value funcs
@DrFaust92 DrFaust92 force-pushed the event_target_refactor branch from a938ff8 to fce5f99 Compare September 4, 2020 11:06
gdavison
gdavison approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSCloudWatchEventTarget_disappears (213.66s)
--- PASS: TestAccAWSCloudWatchEventTarget_sqs (262.07s)
--- PASS: TestAccAWSCloudWatchEventTarget_missingTargetId (262.10s)
--- PASS: TestAccAWSCloudWatchEventTarget_ssmDocument (265.99s)
--- PASS: TestAccAWSCloudWatchEventTarget_ecsWithBlankTaskCount (296.98s)
--- PASS: TestAccAWSCloudWatchEventTarget_ecs (297.76s)
--- PASS: TestAccAWSCloudWatchEventTarget_input_transformer (306.77s)
--- PASS: TestAccAWSCloudWatchEventTarget_kinesis (310.75s)
--- PASS: TestAccAWSCloudWatchEventTarget_full (312.31s)
--- PASS: TestAccAWSCloudWatchEventTarget_basic (331.07s)
--- PASS: TestAccAWSCloudWatchEventTarget_batch (388.22s)

@gdavison gdavison added this to the v3.14.0 milestone Oct 30, 2020
gdavison added a commit that referenced this pull request Oct 30, 2020
@gdavison
Update CHANGELOG for #11685
360abbc
@gdavison gdavison merged commit 4a0b1af into hashicorp:master Oct 30, 2020
@ghost
Copy link

ghost commented Nov 6, 2020

This has been released in version 3.14.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 30, 2020
@DrFaust92 DrFaust92 deleted the event_target_refactor branch April 15, 2021 10:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@slapula slapula slapula approved these changes

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DrFaust92 @gdavison @slapula