Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for time based retention policies in DLM #11456

Closed
civ0 opened this issue Jan 2, 2020 · 5 comments · Fixed by #23880
Closed

Implement support for time based retention policies in DLM #11456

civ0 opened this issue Jan 2, 2020 · 5 comments · Fixed by #23880
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/dlm Issues and PRs that pertain to the dlm service.
Milestone

Comments

@civ0
Copy link

civ0 commented Jan 2, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS DLM supports time based retention policies since end of November 2019: https://aws.amazon.com/about-aws/whats-new/2019/11/data-lifecycle-manager-supports-time-based-retention-policies/

This feature is currently not supported by the Terraform AWS Provider.

New or Affected Resource(s)

  • aws/resource_aws_dlm_lifecycle_policy.go

Potential Terraform Configuration

retain_rule {
  type = "Age"
  interval = 7
  interval_unit = "Days"
}
@civ0 civ0 added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 2, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 2, 2020
@bflad bflad added service/dlm Issues and PRs that pertain to the dlm service. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 7, 2020
@aviau
Copy link
Contributor

aviau commented May 17, 2020

This would be really nice!

The count-base retention is much more complicated to manage, for example when you delete disks and the snapshots remain forever because the count stops growing.

@NelsonJeppesen
Copy link

... for example when you delete disks and the snapshots remain forever because the count stops growing.

This is the exact issue I've run into

@breathingdust
Copy link
Member

Hi all 👋 Just letting you know that this is issue is featured on this quarters roadmap. If a PR exists to close the issue a maintainer will review and either make changes directly, or work with the original author to get the contribution merged. If you have written a PR to resolve the issue please ensure the "Allow edits from maintainers" box is checked. Thanks for your patience and we are looking forward to getting this merged soon!

@DrFaust92 DrFaust92 self-assigned this Mar 26, 2022
@github-actions github-actions bot added this to the v4.9.0 milestone Mar 28, 2022
@DrFaust92 DrFaust92 removed their assignment Apr 2, 2022
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 8, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/dlm Issues and PRs that pertain to the dlm service.
Projects
None yet
6 participants