Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for issuing certificates (aws_acm_certificate) by signing a CSR with the private CA aws_acmpca_certificate_authority #10183

Closed
venky999 opened this issue Sep 20, 2019 · 2 comments · Fixed by #10213 or #17850
Labels
new-resource Introduces a new resource. service/acmpca Issues and PRs that pertain to the acmpca service.
Milestone

Comments

@venky999
Copy link

venky999 commented Sep 20, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Support for issuing certificates (aws_acm_certificate) by signing a CSR with a private CA (`aws_acmpca_certificate_authority) from the certificate manager.

Currently there is no option to pass in the CSR to the private CA in order to sign a CSR

example ....

resource "tls_cert_request" "example" {
  key_algorithm   = "RSA"
  private_key_pem = "${file("private_key.pem")}"

  subject {
    common_name  = "example.com"
    organization = "ACME Examples, Inc"
  }
}

resource "aws_acm_certificate" "cert" {
  domain_name       = "internal.example.com"
  certificate_authority_arn = "arn:aws:acm-pca:region:account:certificate-authority/12345678-1234-1234-1234-123456789012"
  csr = "${tls_cert_request.example.cert_request_pem}"
}

New or Affected Resource(s)

aws_acm_certificate

Potential Terraform Configuration

resource "aws_acm_certificate" "cert" {
  domain_name       = "internal.example.com"
  certificate_authority_arn = "arn:aws:acm-pca:region:account:certificate-authority/12345678-1234-1234-1234-123456789012"
  csr = "CSR-BLOB"
}

References

https://docs.aws.amazon.com/sdk-for-go/api/service/acmpca/#ACMPCA.IssueCertificate

@venky999 venky999 added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 20, 2019
@ghost ghost added the service/acm Issues and PRs that pertain to the acm service. label Sep 20, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 20, 2019
@venky999 venky999 changed the title Support for issuing certificates (aws_acm_certificate) by signing a CSR with the private CA (`aws_acmpca_certificate_authority) from the certificate manager. Support for issuing certificates (aws_acm_certificate) by signing a CSR with the private CA aws_acmpca_certificate_authority Sep 20, 2019
@bflad bflad added new-resource Introduces a new resource. service/acmpca Issues and PRs that pertain to the acmpca service. and removed enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. service/acm Issues and PRs that pertain to the acm service. labels May 18, 2020
@github-actions github-actions bot added this to the v3.32.0 milestone Mar 11, 2021
@ghost
Copy link

ghost commented Mar 12, 2021

This has been released in version 3.32.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 11, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. service/acmpca Issues and PRs that pertain to the acmpca service.
Projects
None yet
2 participants