Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update resource_aws_route53_health_check to support Enabling/Disabling Healthcheck #10117

Closed
Giri-Chintala opened this issue Sep 16, 2019 · 4 comments · Fixed by #14614
Closed
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/route53 Issues and PRs that pertain to the route53 service.
Milestone

Comments

@Giri-Chintala
Copy link

AWS HealthCheck API supports Enabling/Disabling Healthcheck. https://docs.aws.amazon.com/Route53/latest/APIReference/API_UpdateHealthCheck.html#API_UpdateHealthCheck_RequestSyntax#Disabled

Currently, terraform module resource_aws_route53_health_check is not handling disabled state information. Request is to update terraform to include HealthCheck disabled state information.

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

I'm planning to work on this enhancement.

Description

HealthCheck Disabled state information is helpful for finding/manipulating Health status of Route53 HealthCheck.

New or Affected Resource(s)

  • aws_route53_health_check

Potential Terraform Configuration

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

References

https://docs.aws.amazon.com/Route53/latest/APIReference/API_UpdateHealthCheck.html#API_UpdateHealthCheck_RequestSyntax#Disabled

  • #0000
@Giri-Chintala Giri-Chintala added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 16, 2019
@ghost ghost added the service/route53 Issues and PRs that pertain to the route53 service. label Sep 16, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 16, 2019
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Dec 6, 2019
@artburkart
Copy link
Contributor

This is a duplicate of #8937

@anGie44
Copy link
Contributor

anGie44 commented Aug 13, 2020

This feature has been merged and will release with v3.2.0 of the Terraform AWS Provider, expected out later today.

@ghost
Copy link

ghost commented Aug 14, 2020

This has been released in version 3.2.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Sep 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/route53 Issues and PRs that pertain to the route53 service.
Projects
None yet
4 participants