-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add path to error when list has too many or few items #826
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @josh-barker 👋 Thank you for submitting this and apologies for the delayed review.
This partially relates to some of the discussion in hashicorp/terraform#31575, so therefore I think this adjustment is acceptable because even if Terraform added the attribute path information to the diagnostic output, it would only show up in newer versions of Terraform while this would cover all cases of Terraform 0.12 and later when providers update their SDK version to one containing this change.
Would you be able to rebase this and ensure the unit testing is passing? Once that is done, we can get this in. Thanks again.
84f1efb
to
8a8f811
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🚀 Thanks so much, @josh-barker
You're welcome @bflad ! 🙂 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR adds the resource path to error messages when a list type either has too many or too few elements.