Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helper/validation: Wrapper function for legacy SchemaValidateFunc #611

Merged
merged 5 commits into from
Dec 18, 2020

Conversation

gnarlex
Copy link
Contributor

@gnarlex gnarlex commented Oct 11, 2020

Adds a wrapper function for validation functions of type SchemaValidateFunc (#534). 📦

It follows a similar implementation as currently used in schema.validateFunc (schema.go#L441-L456)to handle legacy validation functions. This implementation parses the last step of given cty.Path to be used as the second parameter of the legacy validator.

This would help a lot of projects since no "diag" versions of the validation helpers are implemented yet.

@hashicorp-cla
Copy link

hashicorp-cla commented Oct 11, 2020

CLA assistant check
All committers have signed the CLA.

@remyleone
Copy link
Contributor

Copy link
Contributor

@paddycarver paddycarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for the contribution!

@paddycarver paddycarver merged commit da9bdb2 into hashicorp:master Dec 18, 2020
@ghost
Copy link

ghost commented Jan 19, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants