helper/resource/testing_new: update import state testing #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anGie44
force-pushed
the
b-v2-import-state-expect-erro
branch
2 times, most recently
from
6fd9dfb
to
eaf066a
Compare
anGie44
force-pushed
the
b-v2-import-state-expect-erro
branch
from
eaf066a
to
9ad7a3f
Compare
anGie44
changed the title
anGie44
changed the title
bflad
approved these changes
Aug 26, 2020
|
This would also close #528 in its current form. |
Co-authored-by: Brian Flad <bflad417@gmail.com>
paddycarver
approved these changes
Aug 28, 2020
paddycarver
added a commit
that referenced
this pull request
Sep 3, 2020
paddycarver
added a commit
that referenced
this pull request
Sep 4, 2020
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
1 similar comment
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #532
testStepNewImportStatecan now return the error (if any) of the underlying method that imports the resource, thus allowing for error handling w/inrunNewTestwhenstep.ImportStateis set totrue. Special error handling is needed here to account for provider acceptance tests that check for expected errors duringImportStatetest steps as illustrated in #532.Output of previously failing acceptance test: