Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HasChange wrongly returns TRUE on nested shema.Set structures #361

Closed
obourdon opened this issue Mar 17, 2020 · 2 comments · Fixed by #362
Closed

HasChange wrongly returns TRUE on nested shema.Set structures #361

obourdon opened this issue Mar 17, 2020 · 2 comments · Fixed by #362
Labels
bug Something isn't working

Comments

@obourdon
Copy link
Contributor

SDK version

v1.7.0

Relevant provider source code

When investigating Terraform AWS provider issue #11059 I came across some cases where nested schema.Set structures as the one mentioned in the 2nd part of this entry produce unnecessary calls later down in the code

...

Terraform Configuration Files

...

Debug Output

Expected Behavior

HasChange should return false as entries are perfectly equivalent

Actual Behavior

This test returns true because
of reflect.DeepEqual which returns false when traversing Func(s)

Steps to Reproduce

See aforementioned issue

References

@obourdon obourdon added the bug Something isn't working label Mar 17, 2020
@paddycarver
Copy link
Contributor

I believe the merging of #362 resolves this. Please feel free to comment if that's not the case, and we can reopen this issue.

@ghost
Copy link

ghost commented May 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants