helper/resource: Return error with TestCheckResourceAttrPair() when comparing self #335
Conversation
| @@ -1232,6 +1232,14 @@ func TestCheckModuleResourceAttrPair(mpFirst []string, nameFirst string, keyFirs | |||
| } | |||
|
|
|||
| func testCheckResourceAttrPair(isFirst *terraform.InstanceState, nameFirst string, keyFirst string, isSecond *terraform.InstanceState, nameSecond string, keySecond string) error { | |||
| if nameFirst == nameSecond && keyFirst == keySecond { | |||
There was a problem hiding this comment.
While I like the enhancement, I'm inclined to think in V1 maybe this should just be a warning like "you may be comparing an attribute with itself". We can make it an explicit error in V2.... tough one kind of a grey area on if this is a "breaking change" or a bugfix. I could be convinced either way.
There was a problem hiding this comment.
But yeah, would the warning ever get noticed in review/during development vs explicit error, it certainly is valuable in avoiding accidental merging of true == true when a PR is showing all tests passing.
|
@bflad I am going to take the liberty of rebasing with version2 and merging it there as its safer. |
appilon
added
the
breaking-change
…omparing self Reference: hashicorp#334 Also consolidates the unit testing for the function.
appilon
force-pushed
the
b-helper-resource-TestCheckResourceAttrPair-self
branch
from
f4043b8
to
73effae
Compare
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Closes #334
Also consolidates the unit testing for the function.