-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional masking functions to be applied to log fields #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main concern with updating the existing functions in-place here is that the "Message" part of the function names is now not accurate -- we had gotten explicit in the naming so it was very clear what was going to be masked or omitted. I see a few options here:
- Leave/Deprecate
*MaskMessage*
functions with their existing functionality and introduce*MaskLog*
functions that do what is now implemented here. - Introduce new logging options and functions separately, e.g. make new
LoggingOptions.MaskAllFieldValueRegexes
etc. fields, then create mask functions which set only those new fields (which ApplyMask would separately check for), then potentially also create*MaskLog*
functions which set both the old and new fields (thereby implementing both masking concepts)
I personally think the latter of offering provider developers the differing options is better, since sensitive data locations may either be very known but generically filtered (e.g. I always want to filter messages containing an email, but not my special email field) or very unknown (e.g. just never show this type of data ever).
I like the second. Will change the PR tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome to me 🚀 Nice!
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Closes #86