Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusting Field/Filtering Function Naming to be More Concise and Less With-y #78

Merged
merged 6 commits into from
Jul 14, 2022
Merged

Adjusting Field/Filtering Function Naming to be More Concise and Less With-y #78

merged 6 commits into from
Jul 14, 2022

Conversation

detro
Copy link
Contributor

@detro detro commented Jul 14, 2022

Closes #76

@detro detro requested a review from a team as a code owner July 14, 2022 16:24
bflad
bflad approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks really good and should help folks reason about the various functionality. 🚀

@detro detro added this to the v0.6.0 milestone Jul 14, 2022
@detro detro merged commit ebc4e79 into main Jul 14, 2022
@detro detro deleted the detro/76-refactor_naming branch July 14, 2022 16:53
detro pushed a commit that referenced this pull request Jul 15, 2022
Reworked the changelog entries from PR #78
7f24c05
@detro detro mentioned this pull request Jul 15, 2022
Merged
detro pushed a commit that referenced this pull request Jul 15, 2022
Preparing CHANGELOG for v0.6.0 (#82)
a8c50c1 
* Reworked the changelog entries from PR #78

* Preparing CHANGELOG for v0.6.0
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

Consider Adjusting Field/Filtering Function Naming to be More Concise and Less With-y
2 participants
@detro @bflad