Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce tflogtest and tfsdklogtest packages #62

Merged
merged 2 commits into from
May 4, 2022
Merged

Introduce tflogtest and tfsdklogtest packages #62

merged 2 commits into from
May 4, 2022

Conversation

bflad
Copy link
Contributor

@bflad bflad commented May 4, 2022

Closes #61

@bflad bflad added the enhancement New feature or request label May 4, 2022
@bflad bflad added this to the v0.4.0 milestone May 4, 2022
@bflad bflad requested a review from a team as a code owner May 4, 2022 14:53
detro
detro approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@detro detro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabling log testing is a nice touch!

Looks GREAT to me!

@bflad bflad merged commit f5284c7 into main May 4, 2022
@bflad bflad deleted the bflad-test-packages branch May 4, 2022 16:10
@github-actions
Copy link

github-actions bot commented Jun 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@detro detro detro approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

Downstream Logger Unit Testing
2 participants
@bflad @detro