Don't panic when no logger is setup. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't panic, instead just silently swallow logs, when logging isn't set up. This mostly will happen in situations like unit tests where contexts are being created directly, instead of by an SDK layer. Rather than panicking in those situations or intermingling logging output with test output, it's reasonable to just not write logs at all, which is usually what people would want. For people that don't want that, they can call the code to set up the loggers themselves.
bflad
approved these changes
Dec 23, 2021
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't panic, instead just silently swallow logs, when logging isn't set
up. This mostly will happen in situations like unit tests where contexts
are being created directly, instead of by an SDK layer. Rather than
panicking in those situations or intermingling logging output with test
output, it's reasonable to just not write logs at all, which is usually
what people would want. For people that don't want that, they can call
the code to set up the loggers themselves.