Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitting OneOf and NoneOf by "case sensitivity" #45

Merged
merged 2 commits into from
Jun 27, 2022
Merged

Splitting OneOf and NoneOf by "case sensitivity" #45

merged 2 commits into from
Jun 27, 2022

Conversation

detro
Copy link
Contributor

@detro detro commented Jun 27, 2022

  • OneOf and NoneOf are case sensitive
  • OneOfCaseInsensitive and NoneOfCaseInsensitive are ... case insensitive instead

Splitting OneOf and NoneOf by "case sensitivity"
26de3f4 
* `OneOf` and `NoneOf` are case sensitive
* `OneOfCaseInsensitive` and `NoneOfCaseInsensitive` are ... case insensitive instead
@detro detro requested a review from a team as a code owner June 27, 2022 17:07
bflad
bflad approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@bflad bflad added this to the v0.3.0 milestone Jun 27, 2022
@detro detro merged commit 40680ac into main Jun 27, 2022
@detro detro deleted the detro/tweak_OneOf_and_NoneOf branch June 27, 2022 17:11
bflad added a commit that referenced this pull request Jun 29, 2022
@bflad
Update CHANGELOG for consistency with #39, #40, #41, #42, #45
b32b118
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@detro @bflad