Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Tweak autoscaler logic #290

Merged
merged 3 commits into from
Nov 1, 2023
Merged

🔧 Tweak autoscaler logic #290

merged 3 commits into from
Nov 1, 2023

Conversation

jrhouston
Copy link
Contributor

@jrhouston jrhouston commented Oct 31, 2023 •
edited
Loading

This PR tweaks the logic in the AgentPool controller for autoscaling to take into account plans and applys that are already running when computing the replica count for the agent pool deployment. This PR also sets a default terminationGracePeriod on agent deployments to 900 seconds from the default of 30 to allow graceful shutdown of agents that are still busy.

Description

Usage Example

Release Note

Release note for CHANGELOG:

NONE

References

Community Note

  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

@jrhouston jrhouston requested a review from a team as a code owner October 31, 2023 00:59
@github-actions github-actions bot added controller documentation Improvements or additions to documentation golang size/M labels Oct 31, 2023
arybolovlev
arybolovlev approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@arybolovlev arybolovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Could you please add a change log? Thanks!

@jrhouston jrhouston merged commit 2d31cce into main Nov 1, 2023
6 checks passed
@jrhouston jrhouston deleted the tweak-autoscaler-logic branch November 1, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arybolovlev arybolovlev arybolovlev approved these changes

Assignees
No one assigned
Labels
controller documentation Improvements or additions to documentation golang size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrhouston @arybolovlev