Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix output synchronization #289

Merged
merged 6 commits into from
Oct 29, 2023
Merged

🐛 Fix output synchronization #289

merged 6 commits into from
Oct 29, 2023

Conversation

arybolovlev
Copy link
Contributor

@arybolovlev arybolovlev commented Oct 26, 2023

Description

Fix an issue of properly handling special characters when generating string output.

Terraform supports the following types:

This fix adds logic to handle string, number, and bool types as a string and separates them from list, tuple, set, map, and object that are treated as a JSON document.

HCL output example:

output "multiline_string" {
  value     = <<EOT
hello
world
EOT
  sensitive = false
}

Before:

---
apiVersion: v1
kind: ConfigMap
data:
  multiline_string: "hello\nworld"
...

After:

---
apiVersion: v1
kind: ConfigMap
data:
  multiline_string: |
    hello
    world
...

Tests:

Usage Example

N/A.

Release Note

Release note for CHANGELOG:

Workspace: fix an issue of properly handling special characters when generating string output.
Module: fix an issue of properly handling special characters when generating string output.

References

Community Note

  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

@arybolovlev arybolovlev marked this pull request as ready for review October 26, 2023 11:18
@arybolovlev arybolovlev requested a review from a team as a code owner October 26, 2023 11:18
@arybolovlev arybolovlev marked this pull request as draft October 26, 2023 15:02
@arybolovlev arybolovlev marked this pull request as ready for review October 27, 2023 11:19
@github-actions github-actions bot added the test label Oct 27, 2023
@arybolovlev arybolovlev merged commit 55c34e1 into main Oct 29, 2023
9 checks passed
@arybolovlev arybolovlev deleted the fix-output-sync branch October 29, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controller documentation Improvements or additions to documentation golang size/M test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 String output does not have expected format
2 participants