Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wildcardName field to targetWorkspaces #274

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Add wildcardName field to targetWorkspaces #274

merged 4 commits into from
Oct 18, 2023

Conversation

jrhouston
Copy link
Contributor

@jrhouston jrhouston commented Oct 12, 2023

Description

This PR adds a wildcardName field to the autoscaling.targetWorkspaces field of AgentPool, allowing a wildcard search of workspaces as an alternative to specifying each workspace explicitly. This PR also makes the targetWorkspace field optional, defaulting to using all the agents linked to an AgentPool for targeting.

Closes #269

Usage Example

Release Note

Release note for CHANGELOG:

Add `wildcardName` to AgentPool autoscaling configuration

References

Community Note

  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

@jrhouston jrhouston force-pushed the wildcardname branch 2 times, most recently from 51c3305 to 6516b17 Compare October 16, 2023 16:39
@jrhouston jrhouston marked this pull request as ready for review October 16, 2023 16:41
@jrhouston jrhouston requested a review from a team as a code owner October 16, 2023 16:41
@jrhouston jrhouston changed the title WIP: add wildcardName field to targetWorkspaces Add wildcardName field to targetWorkspaces Oct 16, 2023
@jrhouston jrhouston merged commit 082ac4a into main Oct 18, 2023
7 checks passed
@jrhouston jrhouston deleted the wildcardname branch October 18, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Simplify AgentPool Autoscaling
2 participants