Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix panic when executionMode is set to agent but agentPool is not set #242

Merged
merged 3 commits into from
Aug 18, 2023
Merged

🐛 Fix panic when executionMode is set to agent but agentPool is not set #242

merged 3 commits into from
Aug 18, 2023

Conversation

arybolovlev
Copy link
Contributor

@arybolovlev arybolovlev commented Aug 18, 2023 •
edited
Loading

Description

Usage Example

N/A.

Release Note

Release note for CHANGELOG:

`Workspace`: fix an issue when the Operator panics when `spec.executionMode` is configured as `agent` but `spec.agentPool` is not set which is mandatory in this case.

References

Fix: #241

Community Note

  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

@github-actions github-actions bot added api documentation Improvements or additions to documentation golang test size/L labels Aug 18, 2023
@arybolovlev arybolovlev marked this pull request as ready for review August 18, 2023 14:15
@arybolovlev arybolovlev requested a review from a team as a code owner August 18, 2023 14:15
alexsomesan
alexsomesan approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦸‍♂️ 🚀

@arybolovlev
Copy link
Contributor Author

The api-reference.md file was updated automatically due to changes in the tool that generates it. 😅

@arybolovlev arybolovlev merged commit 86a567d into main Aug 18, 2023
6 checks passed
@arybolovlev arybolovlev deleted the fix-workspace-panic branch August 18, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsomesan alexsomesan alexsomesan approved these changes

Assignees
No one assigned
Labels
api controller documentation Improvements or additions to documentation golang size/L test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 panic when executionMode is agent but agentPool is not specified
2 participants
@arybolovlev @alexsomesan