Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Remove auto apply from Run to inherit it from the Workspace #170

Merged
merged 4 commits into from
May 12, 2023
Merged

🚀 Remove auto apply from Run to inherit it from the Workspace #170

merged 4 commits into from
May 12, 2023

Conversation

arybolovlev
Copy link
Contributor

@arybolovlev arybolovlev commented May 10, 2023 •
edited
Loading

Description

This PR removed the automatically apply method from the Module when a new Run is executed. Instead, the apply method is now inherited from the Workspace in which the Run is executed.

Usage Example

N/A.

Release Note

Release note for CHANGELOG:

`Module`: The Run now adopts the apply method of the Workspace in which it is executed. If the apply method is set to 'manual', the Run will remain on hold until it receives manual approval or rejection for the application or cancellation of the Run.

References

Community Note

  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

@arybolovlev arybolovlev marked this pull request as ready for review May 11, 2023 07:11
@arybolovlev arybolovlev requested a review from a team as a code owner May 11, 2023 07:11
alexsomesan
alexsomesan approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran into this yesterday and got confused. Thanks for addressing it.

@arybolovlev arybolovlev merged commit c18ca01 into main May 12, 2023
@arybolovlev arybolovlev deleted the update-module-auto-apply branch May 12, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsomesan alexsomesan alexsomesan approved these changes

Assignees
No one assigned
Labels
controller golang kind:module size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Module shouldn't always auto-apply
2 participants
@arybolovlev @alexsomesan