Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Add support for Notifications #107

Merged
merged 13 commits into from
Mar 27, 2023
Merged

Conversation

arybolovlev
Copy link
Contributor

@arybolovlev arybolovlev commented Mar 7, 2023

Description

This PR adds support for Notifications.

More information about Run Tasks can be found in the TFC documentation.

Check List

  • Add API structures
    • Add Kubernetes API-level validations for new API structures
    • Add documentation[godoc] for new API structures
    • Add custom validations for new API structures
    • Add custom validations tests for new API structures
  • Update Workspace controller to handle Notifications
    • Add support for Notifications
      • Create
      • Update
      • Delete
    • Add tests for Notifications
  • Update documentation
    • Update API reference
    • Update features
    • Add an example
  • Update Helm chart
    • Update CRD

Usage Example

apiVersion: app.terraform.io/v1alpha2
kind: Workspace
metadata:
  name: this
spec:
  organization: kubernetes-operator
  token:
    secretKeyRef:
      name: tfc-operator
      key: token
  name: kubernetes-operator-demo
  notifications:
    - name: this
      type: slack
      enabled: true
      url: https://hooks.slack.com/
      # token: t0k3n
      # emailUsers:
      #   - user@example.com
      # emailAddresses:
      #   - user@example.com
      triggers:
        - assessment:check_failure
        - assessment:drifted
        - assessment:failed
        - run:applying
        - run:completed
        - run:created
        - run:errored
        - run:needs_attention
        - run:planning

Release Note

Release note for CHANGELOG:

`Workspace`: add support for Notifications.

References

N/A.

Community Note

  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

@arybolovlev arybolovlev requested a review from a team as a code owner March 7, 2023 10:39
@arybolovlev arybolovlev marked this pull request as draft March 7, 2023 10:39
@github-actions github-actions bot added size/XL and removed size/L labels Mar 9, 2023
@arybolovlev arybolovlev force-pushed the add-notifications-support branch 2 times, most recently from 47b8c0d to d150190 Compare March 20, 2023 08:51
@arybolovlev arybolovlev marked this pull request as ready for review March 20, 2023 13:12
Copy link
Contributor

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, tried it out – it works! Left one comment

api/v1alpha2/workspace_validation.go Outdated Show resolved Hide resolved
@jrhouston jrhouston merged commit 36c78c8 into main Mar 27, 2023
@jrhouston jrhouston deleted the add-notifications-support branch March 27, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants