Fix for ansible_password #9350
Merged
Fix for ansible_password #9350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
|
@SwampDragons second go new approach |
SwampDragons
approved these changes
Jun 3, 2020
| @@ -779,3 +791,15 @@ func newSigner(privKeyFile string) (*signer, error) { | |||
|
|
|||
| return signer, nil | |||
| } | |||
|
|
|||
| //checkArg Evaluates if argname is in args | |||
| func checkArg(argname string, args []string) bool { | |||
There was a problem hiding this comment.
I like this helper function. Nice job!
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second Go at this.
This will ensure that if user adds ansible_password to their args that it is not overridden by provisioner.
Changes
Added new function for checking if args exist:
https://github.com/gamethis/packer/blob/fix_ansiblepassword/provisioner/ansible/provisioner.go#L796
evaluate args looking for ansible_password before making decisions about adding the ansible_ssh_private_key_file to command line args.
closes ansible-remote requiring private key even when ansible_password provided #9283
https://github.com/gamethis/packer/blob/fix_ansiblepassword/provisioner/ansible/provisioner.go#L573 is to help further address #5412