Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: don't drain node if we can't scale in #911

Open
hsmade opened this issue May 31, 2024 · 1 comment
Open

aws: don't drain node if we can't scale in #911

hsmade opened this issue May 31, 2024 · 1 comment

Comments

@hsmade
Copy link

hsmade commented May 31, 2024

It seems the autoscaler selects and drains a node, to scale in, even if the ASG forbids it (which it finds out after it's done draining and continues to try to delete the VM).

@jrasell
Copy link
Member

jrasell commented Sep 18, 2024

Hi @hsmade and thanks for raising this issue. It sounds like we should add a pre-flight check before draining the node to ensure the node can be terminated from the ASG. I'll mark this for roadmapping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Roadmapping
Development

No branches or pull requests

2 participants