Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checks: add support for delaying the first health check #10864

Open
dnephin opened this issue Aug 17, 2021 · 1 comment
Open

checks: add support for delaying the first health check #10864

dnephin opened this issue Aug 17, 2021 · 1 comment
Labels
theme/health-checks Health Check functionality type/enhancement Proposed improvement or new feature

Comments

@dnephin
Copy link
Contributor

dnephin commented Aug 17, 2021

See #10256 and hashicorp/nomad#9189 for more context

Feature Description

Copied from hashicorp/nomad#9189

[Consul] check option success_before_passing is not honored independently of the value it is configured to. As soon as the first check is successful the instance is marked as passing. Furthermore the first check delay doesn't seem to be guided by interval making it impossible to deterministically define a waiting period before marking a service as ready.

The expected result would be that the instance is marked critical for interval * success_before_passing and only after marked as passing.

Making that change to success_before_passing would be a breaking change, but we can introduce a different field to delay the first health check and prevent it from going to passing.

Use Case(s)

See linked issue and PR.

@jkirschner-hashicorp
Copy link
Contributor

@dnephin: there's a very old enhancement request which feels related: #954. The framing there is mainly about the option to decouple the timing of the first health check from the first interval. IIRC, right now, the first health check is staggered across the first internal to avoid a thundering herd. But some people in that thread had really long intervals for certain kinds of checks and wanted to have the initial check happen faster (or ~immediately).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/health-checks Health Check functionality type/enhancement Proposed improvement or new feature
Projects
None yet
Development

No branches or pull requests

2 participants