Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to CRD. Add helm copier. #406

Merged
merged 2 commits into from
Dec 10, 2020
Merged

Document how to CRD. Add helm copier. #406

merged 2 commits into from
Dec 10, 2020

Commits on Dec 10, 2020

  1. Document how to CRD. Add helm copier. 

    - Add how to create CRDs to contributing.md.
- Add a script that will copy new CRDs to consul-helm in the format
expected. This will reduce manual copying errors.
    @lkysow
    lkysow committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    62a2d96 View commit details
    Browse the repository at this point in the history

  2. Upgrade controller-runtime, hack fix for gen 

    controller-runtime 0.4.1 fixed the issue where they generated types as
Any which was an invalid type
(kubernetes-sigs/controller-tools#505) however
that results in the type for proxy-defaults.config being "byte" which
fails when creating proxy-defaults.

I played around a long time trying to find a type that generates the CRD
as expected and can be unmarshalled as expected and nothing worked so
for now I think it's best to keep it as json.RawMessage and then patch
the generated CRD.
    @lkysow
    lkysow committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    9bea72e View commit details
    Browse the repository at this point in the history