Backport of Fix logic on apigateway that ignores current annotations on services into release/1.1.x #3621
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #3597 to be assessed for backporting due to the inclusion of the label backport/1.1.x.
🚨
The person who merged in the original PR is:
@missylbytes
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Changes proposed in this PR
How I've tested this PR
Built a local image and installed onto a Kind cluster with the following values:
Then I created an API Gateway with the following values:
These resulted in a service that looked like this:
---------- Testing Annotations -------------------------------------------------------------------------------------
I then edited the service to add an additional annotation
And after editing, I made sure this additional annotation was still there:
---------- Testing Labels -------------------------------------------------------------------------------------
I also tested for labels by editing the service and adding a label
Then looked at the service again to make sure the label stayed
How I expect reviewers to test this PR
Check out the tests, test manually
Checklist
Overview of commits