NET-5389- Remove global.acls.nodeSelector and global.acls.annotations from Gateway Resources Jobs #2869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahalsmiller
force-pushed
the
NET-5389
branch
from
9a0bcf3
to
a515c7d
Compare
andrewstucki
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
LGTM those fields are seemingly used for the server-acl-init and server-acl-init-cleanup jobs per:
https://developer.hashicorp.com/consul/docs/k8s/helm#v-global-acls-nodeselector
and this clearly isn't one of those.
t-eckert
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Great work! @joatmon08, this should unblock your blog post once it gets shipped.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Remove global.acls.nodeSelector and global.acls.annotations from the Gateway Resources Job and Gateway Cleanup Job
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: