Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix json tags for fields 1.1.x #2160

Merged
merged 4 commits into from
May 25, 2023
Merged

fix json tags for fields 1.1.x #2160

merged 4 commits into from
May 25, 2023

Conversation

thisisnotashwin
Copy link
Contributor

@thisisnotashwin thisisnotashwin commented May 19, 2023 •
edited
Loading

Changes proposed in this PR:

  • fix json tags

Checklist:

  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@thisisnotashwin thisisnotashwin force-pushed the ashwin/NET-1646-fix-json-tags-for-fields-1.1.x branch from 280ace0 to cb31a6f Compare May 19, 2023 19:57
@thisisnotashwin thisisnotashwin added the pr/no-backport signals that a PR will not contain a backport label label May 19, 2023
@thisisnotashwin thisisnotashwin force-pushed the ashwin/NET-1646-fix-json-tags-for-fields-1.1.x branch from cb31a6f to 3ff05be Compare May 19, 2023 20:03
@malizz
Copy link
Contributor

malizz commented May 22, 2023

Same comment on made on 1.0.x PR. Lint is failing it seems. But otherwise LGTM.

Just to add context: This PR is the to fix backport issue which omitted commits from original PR.

curtbushko
curtbushko suggested changes May 24, 2023
View reviewed changes
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this one for a little bit while I fix some CI errors that should 🤞 make the tests go clear.

I will push through when complete.

@malizz malizz requested a review from curtbushko May 25, 2023 19:05
curtbushko
curtbushko approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the pipelines!

@malizz malizz merged commit 757925b into release/1.1.x May 25, 2023
@malizz malizz deleted the ashwin/NET-1646-fix-json-tags-for-fields-1.1.x branch May 25, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curtbushko curtbushko curtbushko approved these changes

@malizz malizz Awaiting requested review from malizz

Assignees
No one assigned
Labels
pr/no-backport signals that a PR will not contain a backport label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thisisnotashwin @malizz @curtbushko