Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding podDistruptionBudget & podAntiAffinity on consul-injector-deployments #1278

Closed
WJay-tec opened this issue Jun 15, 2022 · 4 comments
Closed
Labels
type/enhancement New feature or request

Comments

@WJay-tec
Copy link
Contributor

WJay-tec commented Jun 15, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Is your feature request related to a problem? Please describe.

We have encountered issues where our consul-connect-injector pods are both evicted at the same time, most likely due to a scale down by cluster-autoscaler

Feature Description

This feature will help to make sure consul-connect-injector pods will always have at least 1 replica up and running, and at the same time have the injectors running in separate node to prevent the injectors from failing during the event of a nodal failure (Previous discussion in a separate issue #1134)

Use Case(s)

This is applicable to all applications

Contributions

Yes

@WJay-tec WJay-tec added the type/enhancement New feature or request label Jun 15, 2022
@WJay-tec WJay-tec changed the title Adding podDistruptionBudget on consul-injector-deployments Adding podDistruptionBudget & podAntiAffinity on consul-injector-deployments Jun 15, 2022
@david-yu
Copy link
Contributor

@WJay-tec This sounds like a great feature. Would you be willing to contribute with a PR, there exists a podDisruptionBudget and podAntiAffinity config for servers in Consul K8s as an example.

@WJay-tec
Copy link
Contributor Author

@david-yu sure will raise a PR for this thanks!

@WJay-tec
Copy link
Contributor Author

Closing this issue as the PR is already merged

@david-yu
Copy link
Contributor

@WJay-tec Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants