From cbb7409c6a343e1766b2bf2a13ab1b04c6931919 Mon Sep 17 00:00:00 2001 From: Melisa Griffin Date: Tue, 8 Aug 2023 09:46:07 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Nathan Coleman --- control-plane/api-gateway/binding/result.go | 2 +- control-plane/api-gateway/common/helm_config.go | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/control-plane/api-gateway/binding/result.go b/control-plane/api-gateway/binding/result.go index a78a04052c..1953d4836c 100644 --- a/control-plane/api-gateway/binding/result.go +++ b/control-plane/api-gateway/binding/result.go @@ -247,7 +247,7 @@ var ( // direct port conflicts defined by the user (two listeners on the same port) vs a port conflict because we map // privileged ports by adding the value passed into the gatewayClassConfig. // (i.e. one listener on 80 with a privileged port mapping of 2000, and one listener on 2080 would conflict). - errListenerMappedToPrivilegedPortMapping = errors.New("listener conflicts with privileged port mapped by Gateway Class Config privileged port mapping setting") + errListenerMappedToPrivilegedPortMapping = errors.New("listener conflicts with privileged port mapped by GatewayClassConfig privileged port mapping setting") ) // listenerValidationResult contains the result of internally validating a single listener diff --git a/control-plane/api-gateway/common/helm_config.go b/control-plane/api-gateway/common/helm_config.go index 048eb16a49..ecd9d42c29 100644 --- a/control-plane/api-gateway/common/helm_config.go +++ b/control-plane/api-gateway/common/helm_config.go @@ -35,6 +35,8 @@ type HelmConfig struct { // and should create SecurityContextConstraints. EnableOpenShift bool + // MapPrivilegedServicePorts is the value which Consul will add to privileged container port values (ports < 1024) + // defined on a Gateway. MapPrivilegedServicePorts int }